-
-
Notifications
You must be signed in to change notification settings - Fork 353
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
remark-parse: fix support for image-like footnotes
Previously, image-like footnotes (such as `Hello![^foo]`) were seen as image references if `footnotes: true` was passed. However, it makes much more sense, as pointed out in GH-283, that they are footnotes instead. This commit makes that happen. Closes GH-283.
- Loading branch information
Showing
4 changed files
with
672 additions
and
53 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,14 @@ | ||
foo[^abc] bar. foo[^xyz] bar | ||
|
||
And some more tests for “image like” footnotes, related to: | ||
<https://github.com/remarkjs/remark/issues/283>: | ||
|
||
Hello[^footnote] | ||
Hello![^footnote] | ||
Hello! [^footnote] | ||
|
||
[^abc]: Baz baz | ||
|
||
[^xyz]: Baz | ||
|
||
[^footnote]: Some definition. |
Oops, something went wrong.