Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] test: migrate test suite to node:test #1163

Closed

Conversation

ChristianMurphy
Copy link
Member

Initial checklist

  • I read the support docs
  • I read the contributing guide
  • I agree to follow the code of conduct
  • I searched issues and couldn’t find anything (or linked relevant results below)
  • If applicable, I’ve added docs and tests

Description of changes

Migrates test suite from tape to node:test.

TODO:

  • resolve race condition in fixture test suite

@github-actions github-actions bot added the 👋 phase/new Post is being triaged automatically label May 16, 2023
@github-actions

This comment has been minimized.

@ChristianMurphy ChristianMurphy added the 🕸️ area/tests This affects tests label May 16, 2023
@wooorm
Copy link
Member

wooorm commented May 16, 2023

Shoot, sorry, just did that :'(

@ChristianMurphy
Copy link
Member Author

No worries, thanks @wooorm !

@ChristianMurphy ChristianMurphy deleted the test/node-test branch May 16, 2023 17:08
@wooorm
Copy link
Member

wooorm commented May 16, 2023

Here’s the commit: f4ac350.

What race condition did you run into?

@github-actions

This comment was marked as resolved.

@ChristianMurphy
Copy link
Member Author

in fixtures a bunch of

✖ {fixture name}
  'test did not finish before its parent and was cancelled'

it looks like you resolved that by awaiting t.test?

@wooorm wooorm added the 🙅 no/wontfix This is not (enough of) an issue for this project label May 16, 2023
@wooorm
Copy link
Member

wooorm commented May 16, 2023

Yeah! await t.test is important, didn’t know that when I started using node:test earlier either.

But tests are so fast now with node:test, it finishes immediately.
Before, tape was super slow and running into memory stuff, hence the setImmediates!

@github-actions github-actions bot added 👎 phase/no Post cannot or will not be acted on and removed 👋 phase/new Post is being triaged automatically labels May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🕸️ area/tests This affects tests 🙅 no/wontfix This is not (enough of) an issue for this project 👎 phase/no Post cannot or will not be acted on
Development

Successfully merging this pull request may close these issues.

None yet

2 participants