New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix website design #1241
base: website
Are you sure you want to change the base?
Fix website design #1241
Conversation
Heya!
Generally, adding scroll isn’t bad per se, but I don’t see lots of value either? Can you explain why? Is it really worth including a library for this? Browsers support smooth scrolling too: https://developer.mozilla.org/en-US/docs/Web/API/Window/scrollTo |
Ping! |
Hey @wooorm!
I've also created a script that will automatically update all packages in the npm command output, reflecting the real output in commit 6f781e1. I hope this answers all your questions. This is my first contribution to any open-source project, so feel free to give me pointers on how to make better changes. Thanks. |
That’s why the size of the cover is smaller than the entire screen. We could also use 85 or 90 if you prefer to see some text?
And that’s very nice for your own development. Typically, open source projects already use a consistent style already. So I’d recommend turning off these things when you contribute. You can always ask to see if folks want a separate PR formatting things!
👍
That’s very cool, but seems a bit much to me. I’d rather not slow everyone down that views the website and use their data plans for this.
Welcome! I recommend saying that you’re new early on! |
I've made the initial image cover entire screen like in the screenshot, ive added smoothscroll to the button and made it a button and I've added overflow:auto to the code gits