Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add remark-github-blockquote-alert to list of plugins #1298

Merged
merged 2 commits into from Apr 10, 2024

Conversation

jaywcjlove
Copy link
Contributor

Initial checklist

  • I read the support docs
  • I read the contributing guide
  • I agree to follow the code of conduct
  • I searched issues and couldn’t find anything (or linked relevant results below)
  • If applicable, I’ve added docs and tests

Description of changes

Add remark-github-blockquote-alert

@github-actions github-actions bot added 👋 phase/new Post is being triaged automatically 🤞 phase/open Post is being triaged manually and removed 👋 phase/new Post is being triaged automatically labels Mar 15, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (d0886dc) to head (ca34563).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1298   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines          142       142           
=========================================
  Hits           142       142           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChristianMurphy
Copy link
Member

Hey @jaywcjlove!
Thanks for sharing!

This appears to focus on the HTML output and does not modify the markdown?
If so you may want to consider a rehype plugin instead.

There is one https://github.com/chrisweb/rehype-github-alerts which may suit your needs.
There is also an open issue on rehypejs/rehype-github#3 which could standardize this if needed.

@jaywcjlove
Copy link
Contributor Author

@ChristianMurphy Oh, I didn't pay attention to it.

@wooorm
Copy link
Member

wooorm commented Apr 3, 2024

remark-github-beta-blockquote-admonitions is listed already too.
And indeed, perhaps better to do this in HTML/rehype, chrisweb/rehype-github-alerts?

What should we do with this PR? @jaywcjlove @ChristianMurphy?

@jaywcjlove
Copy link
Contributor Author

jaywcjlove commented Apr 3, 2024

Both remark-github-beta-blockquote-admonitions and rehype-github-alerts have historical baggage, supporting old syntax, which should now be removable.

remark-github-beta-blockquote-admonitions does not generate icons, so you need to add icons manually through CSS.

Therefore, I think rehype-github-alerts is better.

remark-github-blockquote-alert did not implement the old syntax and instead expanded with a new syntax for internationalization, as follows:

> [!NOTE/笔记]  
> Useful information that users should know, even when skimming content.

@wooorm So I should only use my own remark-github-blockquote-alert.

@wooorm @ChristianMurphy I forgot to ask if merging another option would be possible. If not needed, I will close it.

@wooorm
Copy link
Member

wooorm commented Apr 3, 2024

To summarize, you are saying:

  • remark-github-beta-blockquote-admonitions is not really maintained
  • rehype-github-alerts is maintained but also includes code for an older syntax.

remark-github-blockquote-alert

I do wonder about what Christian also asked: would a rehype plugin not be better?

And if you’d make it a rehype plugin, then it would be almost the existing rehype-github-alerts. Is it really worth it to have 2 plugins?

@jaywcjlove
Copy link
Contributor Author

When I was developing this plugin, I was only aiming to solve the issue in my other package uiwjs/react-markdown-preview#258, and added an internationalization option for another project of mine. I didn't pay attention to rehype-github-alerts at that time. Now it has been integrated into multiple projects of mine, remark-github-blockquote-alert has completed its mission on my side.

If rehype-github-alerts removes support for the old syntax and supports the special syntax I want, > [!NOTE/笔记], I am willing to abandon my project.

@wooorm

@wooorm
Copy link
Member

wooorm commented Apr 4, 2024

remark-github-blockquote-alert has completed its mission on my side.

That sounds like you are not interested in maintaining your project? 🤔

the special syntax I want,

🤔 That sounds like your project does not match GitHub? It matches GH in some ways, but also matches your own preferences?

@jaywcjlove
Copy link
Contributor Author

remark-github-blockquote-alert has completed its mission on my side.

That sounds like you are not interested in maintaining your project? 🤔

the special syntax I want,

🤔 That sounds like your project does not match GitHub? It matches GH in some ways, but also matches your own preferences?

I have contributed to nearly 300 code repositories in the open-source community and published over 500 packages through npm. However, things have been tough lately. I lost my job at the end of last year, and I currently have no income and haven't managed to overcome this situation yet. Recently, someone raised a new issue (#258) in a project, and I noticed that the needed plugins were not listed in the remark and rehype projects. However, I found the solution to this problem to be quite simple, so I started developing a new package to address it.

I have contributed 4 plugins to rehype and have been actively maintaining them. I simply feel that if there are two similar plugins, the official preference is to keep only one, and I am willing to abandon my own.

image

@wooorm

@wooorm
Copy link
Member

wooorm commented Apr 10, 2024

I have contributed to nearly 300 code repositories in the open-source community and published over 500 packages through npm.

Yes, I know you’re prolific and contribute a lot! 😊 I appreciate it!

However, things have been tough lately. I lost my job at the end of last year, and I currently have no income and haven't managed to overcome this situation yet.

I am sorry to hear that!

I have contributed 4 plugins to rehype and have been actively maintaining them. I simply feel that if there are two similar plugins, the official preference is to keep only one, and I am willing to abandon my own.

Right, good point.


I am fine adding this for now. If it becomes unmaintained, or people have problems with the mistmatch between what it does and what they think it does, we can revisit this later!

@wooorm wooorm changed the title Add remark-github-blockquote-alert Add remark-github-blockquote-alert to list of plugins Apr 10, 2024
@wooorm wooorm merged commit 6e0a70b into remarkjs:main Apr 10, 2024
2 checks passed

This comment has been minimized.

@wooorm wooorm added the 💪 phase/solved Post is done label Apr 10, 2024
@github-actions github-actions bot removed the 🤞 phase/open Post is being triaged manually label Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💪 phase/solved Post is done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants