Support responsive dark mode #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is only supported for the `img-png` and `img-svg` strategies. Dark mode is supported using a responsive `<picture>` element. Closes #6
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 1 1
Lines 263 365 +102
Branches 41 51 +10
==========================================
+ Hits 263 365 +102 ☔ View full report in Codecov by Sentry. |
|
@stereobooster would you be willing to review this? I’m mainly wondering if the test fixtures are as you expected. |
stereobooster
approved these changes
Jan 9, 2024
The meta tag `color-scheme` is now used to determine whether the light or dark diagram should be used by default when using a responsive picture element.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is only supported for the
img-pngandimg-svgstrategies. Dark mode is supported using a responsive<picture>element.Closes #6