-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/improve group by key types #143
Merged
TkDodo
merged 16 commits into
remeda:master
from
TkDodo:feature/improve-groupBy-key-types
Nov 11, 2021
Merged
Feature/improve group by key types #143
TkDodo
merged 16 commits into
remeda:master
from
TkDodo:feature/improve-groupBy-key-types
Nov 11, 2021
Commits on Sep 6, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 94c6c1e - Browse repository at this point
Copy the full SHA 94c6c1eView commit details
Commits on Sep 12, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 4e07d67 - Browse repository at this point
Copy the full SHA 4e07d67View commit details
Commits on Nov 1, 2020
-
Configuration menu - View commit details
-
Copy full SHA for f15eefc - Browse repository at this point
Copy the full SHA f15eefcView commit details
Commits on Jun 29, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 7d7e85c - Browse repository at this point
Copy the full SHA 7d7e85cView commit details
Commits on Jul 15, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 33aa1b4 - Browse repository at this point
Copy the full SHA 33aa1b4View commit details
Commits on Jul 21, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 5a69bd4 - Browse repository at this point
Copy the full SHA 5a69bd4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 893b537 - Browse repository at this point
Copy the full SHA 893b537View commit details
Commits on Aug 13, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 60a5770 - Browse repository at this point
Copy the full SHA 60a5770View commit details -
by inferring the type of the key from the provided function; it must still extend a PropertyKey because that's what an object needs as index
Configuration menu - View commit details
-
Copy full SHA for 6bed375 - Browse repository at this point
Copy the full SHA 6bed375View commit details
Commits on Nov 9, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 0b308af - Browse repository at this point
Copy the full SHA 0b308afView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6d07266 - Browse repository at this point
Copy the full SHA 6d07266View commit details
Commits on Nov 10, 2021
-
reverse type inference gets even better with this
Configuration menu - View commit details
-
Copy full SHA for 77617b5 - Browse repository at this point
Copy the full SHA 77617b5View commit details -
make returnType of groupBy partial
we can't really access keys directly because they might not exist at runtime, and Partial makes sure of that while still preserving the better key types. this also works well with Object.entries in TS 4.3 and above
Configuration menu - View commit details
-
Copy full SHA for 2ef925c - Browse repository at this point
Copy the full SHA 2ef925cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 70438f6 - Browse repository at this point
Copy the full SHA 70438f6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 83e04aa - Browse repository at this point
Copy the full SHA 83e04aaView commit details -
Configuration menu - View commit details
-
Copy full SHA for b66c416 - Browse repository at this point
Copy the full SHA b66c416View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.