feat(some): Add some
#646
Open
feat(some): Add some
#646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 15 commits
April 20, 2024 00:25
… case it gets resolved
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit d5bc185:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #646 +/- ##
==========================================
+ Coverage 98.41% 98.63% +0.21%
==========================================
Files 127 156 +29
Lines 7954 11263 +3309
Branches 724 945 +221
==========================================
+ Hits 7828 11109 +3281
- Misses 123 151 +28
Partials 3 3 ☔ View full report in Codecov by Sentry. |
cjquines
reviewed
Apr 22, 2024
Comment on lines
+34
to
+42
| * @example | ||
| * // using `R.some` as a type predicate within `conditional` | ||
| * const result = R.pipe( | ||
| * data, | ||
| * R.conditional( | ||
| * [some(isNumber), val => {...}] | ||
| * ... | ||
| * ) | ||
| * ) |
There was a problem hiding this comment.
question: if there's no issue here, maybe we should just drop this example? this seems like it should belong in conditional, not some, which i expect to be used in way more contexts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing with #624, implementing
some. This is a branch from #631 so merge this one first.Make sure that you:
src/index.tsmapping.mdWe use semantic PR titles to automate the release process!
https://conventionalcommits.org
PRs should be titled following using the format:
< TYPE >(< scope >)?: descriptionAvailable Types:
feat: new functions, and changes to a function's type that would impact users.fix: changes to the runtime behavior of an existing function, or refinements to it's type that shouldn't impact most users.perf: changes to function implementations that improve a functions runtime performance.refactor: changes to function implementations that are neitherfixnorperftest: tests-only changes (transparent to users of the function).docs: changes to the documentation of a function or the documentation site.build,ci,style,chore, andrevert: are only relevant for the internals of the library.For scope put the name of the function you are working on (either new or
existing).