Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): add missing dependency cross-env #860

Merged
merged 1 commit into from Feb 13, 2021
Merged

chore(deps): add missing dependency cross-env #860

merged 1 commit into from Feb 13, 2021

Conversation

ocavue
Copy link
Member

@ocavue ocavue commented Feb 12, 2021

Description

I found that in Github Codespace, the git hooks don't work well because of cross-env-shell: not found.

node ➜ ~/workspace/remirror (beta) $ git checkout -b fix_deps
Switched to a new branch 'fix_deps'
husky > post-checkout (node v14.15.4)
sh: 1: sh: 1: cross-env-shell: not foundcross-env-shell: not found

husky > post-checkout hook failed (cannot be bypassed with --no-verify due to Git specs)

BTW, when I wrote this PR, I just found out that cross-env was in maintenance mode. cross-env will continue to support the latest Node.js version as we as to fix security/critical bugs, so it should be ok to continue to use it. I just post this as a small piece of news.

Checklist

  • I have read the contributing document.
  • My code follows the code style of this project and pnpm fix completed successfully.
  • I have updated the documentation where necessary.
  • New code is unit tested and all current tests pass when running pnpm test.

@changeset-bot
Copy link

changeset-bot bot commented Feb 12, 2021

⚠️ No Changeset found

Latest commit: 9060984

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ocavue ocavue requested a review from ifiokjr February 13, 2021 14:44
Copy link
Member

@ifiokjr ifiokjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot 👍

@ifiokjr ifiokjr merged commit d33e506 into beta Feb 13, 2021
@ifiokjr ifiokjr deleted the fix_deps branch February 13, 2021 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants