Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove all TypeScript references when isTypeScript is passed as false to remix.init #50

Merged
merged 1 commit into from
Aug 25, 2022
Merged

feat: remove all TypeScript references when isTypeScript is passed as false to remix.init #50

merged 1 commit into from
Aug 25, 2022

Conversation

MichaelDeBoey
Copy link
Member

@MichaelDeBoey MichaelDeBoey commented Apr 20, 2022 •
edited

@MichaelDeBoey MichaelDeBoey mentioned this pull request Apr 20, 2022
Closed
This was referenced Apr 27, 2022
Closed
Closed
This was referenced May 2, 2022
Merged
Closed
@MichaelDeBoey MichaelDeBoey mentioned this pull request May 10, 2022
Merged
@machour
Copy link
Collaborator

machour commented Jun 8, 2022

#47 was merged 👍🏼

@MichaelDeBoey MichaelDeBoey mentioned this pull request Jul 18, 2022
Merged
@williamrjribeiro
Copy link

Hello! So much time has passed and this stack is still broken when choosing JavaScript instead of TypeScript 😿. I know this PR is still a Draft but I'll start adding feedback already. I just wanna use JS with Remix 💿

williamrjribeiro
williamrjribeiro reviewed Aug 2, 2022
View reviewed changes
Copy link

@williamrjribeiro williamrjribeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope my comments help this PR to be concluded and merged sooner. 🙏

Cheers!

remix.init/index.js Show resolved Hide resolved
remix.init/index.js Show resolved Hide resolved
remix.init/index.js Show resolved Hide resolved
remix.init/index.js Show resolved Hide resolved
remix.init/index.js Show resolved Hide resolved
@MichaelDeBoey MichaelDeBoey removed the request for review from mcansh August 25, 2022 21:03
@MichaelDeBoey MichaelDeBoey assigned mcansh and unassigned kentcdodds Aug 25, 2022
@MichaelDeBoey MichaelDeBoey marked this pull request as ready for review August 25, 2022 21:03
@MichaelDeBoey MichaelDeBoey force-pushed the add-convert-to-js branch 2 times, most recently from 81b79d4 to b66300e Compare August 25, 2022 21:27
@MichaelDeBoey
Copy link
Member Author

@williamrjribeiro @mcansh This one is good to go I think 👍

@mcansh
Copy link
Contributor

mcansh commented Aug 25, 2022

@williamrjribeiro @mcansh This one is good to go I think 👍

can you fix the merge conflict? 😬

@MichaelDeBoey
Copy link
Member Author

@mcansh You were too fast 🙈

@mcansh
Copy link
Contributor

mcansh commented Aug 25, 2022

@mcansh You were too fast 🙈

just doing one final check before logging off 😆

@MichaelDeBoey
Copy link
Member Author

@mcansh I added eslint-plugin-cypress to the wrong package.json 😅
Fixed now too, so ESLint will be OK now 👍

@MichaelDeBoey MichaelDeBoey merged commit 51caeb6 into remix-run:main Aug 25, 2022
@MichaelDeBoey MichaelDeBoey deleted the add-convert-to-js branch August 25, 2022 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcansh mcansh mcansh approved these changes

@machour machour Awaiting requested review from machour

@williamrjribeiro williamrjribeiro Awaiting requested review from williamrjribeiro

Assignees

@mcansh mcansh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@MichaelDeBoey @machour @williamrjribeiro @mcansh @kentcdodds