Fix hash replacement redirect

remix-run · Apr 1, 2018 · 7324006 · 7324006
1 parent f147077
commit 7324006
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/modules/createHashHistory.js b/modules/createHashHistory.js
@@ -45,11 +45,11 @@ const getHashPath = () => {
 const pushHashPath = path => (window.location.hash = path);
 
 const replaceHashPath = path => {
-  const hashIndex = window.location.href.indexOf("#");
+  let href = window.location.href;
+  const hashIndex = href.indexOf("#");
+  if (hashIndex !== -1) href = href.slice(0, hashIndex);
 
-  window.location.replace(
-    window.location.href.slice(0, hashIndex >= 0 ? hashIndex : 0) + "#" + path
-  );
+  window.location.replace(href + "#" + path);
 };
 
 const createHashHistory = (props = {}) => {