Warn when path does not contain basename (#453)

This is only a problem when getting the path from the URL.
remix-run · Apr 20, 2017 · fbf5f47 · fbf5f47
1 parent a647c5d
commit fbf5f47
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/modules/createBrowserHistory.js b/modules/createBrowserHistory.js
@@ -59,6 +59,12 @@ const createBrowserHistory = (props = {}) => {
 
     let path = pathname + search + hash
 
+    warning(
+      !(basename && path.indexOf(basename) !== 0),
+      'You are attempting to use a basename on a page whose URL path does not begin ' +
+      'with the basename. Expected path "' + path + '" to begin with "' + basename + '".'
+    )
+
     if (basename)
       path = stripPrefix(path, basename)
 

diff --git a/modules/createHashHistory.js b/modules/createHashHistory.js
@@ -74,6 +74,12 @@ const createHashHistory = (props = {}) => {
   const getDOMLocation = () => {
     let path = decodePath(getHashPath())
 
+    warning(
+      !(basename && path.indexOf(basename) !== 0),
+      'You are attempting to use a basename on a page whose URL path does not begin ' +
+      'with the basename. Expected path "' + path + '" to begin with "' + basename + '".'
+    )
+
     if (basename)
       path = stripPrefix(path, basename)