fix: respect the replace prop if it is defined (#8779)

* Fix: respect the replace prop if it is defined

* Update contributors.yml

contributors.yml

@@ -63,4 +63,6 @@
 - turansky
 - underager
 - vijaypushkin
+- rtmann
+- williamsdyyz
 - vikingviolinist

packages/react-router-dom/__tests__/link-push-test.tsx

@@ -222,4 +222,65 @@ describe("Link push and replace", () => {
       `);
     });
   });
+
+  describe("to the same page with replace={false}, when it is clicked", () => {
+    it("performs a push", () => {
+      function Home() {
+        return (
+          <div>
+            <h1>Home</h1>
+            <Link to="." replace={false}>
+              Home
+            </Link>
+            <ShowNavigationType />
+          </div>
+        );
+      }
+
+      function About() {
+        return <h1>About</h1>;
+      }
+
+      let renderer: TestRenderer.ReactTestRenderer;
+      TestRenderer.act(() => {
+        renderer = TestRenderer.create(
+          <MemoryRouter initialEntries={["/home"]}>
+            <Routes>
+              <Route path="home" element={<Home />} />
+              <Route path="about" element={<About />} />
+            </Routes>
+          </MemoryRouter>
+        );
+      });
+
+      let anchor = renderer.root.findByType("a");
+
+      TestRenderer.act(() => {
+        anchor.props.onClick(
+          new MouseEvent("click", {
+            view: window,
+            bubbles: true,
+            cancelable: true,
+          })
+        );
+      });
+
+      expect(renderer.toJSON()).toMatchInlineSnapshot(`
+        <div>
+          <h1>
+            Home
+          </h1>
+          <a
+            href="/home"
+            onClick={[Function]}
+          >
+            Home
+          </a>
+          <p>
+            PUSH
+          </p>
+        </div>
+      `);
+    });
+  });
 });

packages/react-router-dom/index.tsx

@@ -343,7 +343,7 @@ export const Link = React.forwardRef<HTMLAnchorElement, LinkProps>(
     {
       onClick,
       reloadDocument,
-      replace = false,
+      replace,
       state,
       target,
       to,
@@ -641,9 +641,11 @@ export function useLinkClickHandler<E extends Element = HTMLAnchorElement>(
         event.preventDefault();
 
         // If the URL hasn't changed, a regular <a> will do a replace instead of
-        // a push, so do the same here.
+        // a push, so do the same here unless the replace prop is explcitly set
         let replace =
-          !!replaceProp || createPath(location) === createPath(path);
+          replaceProp !== undefined
+            ? replaceProp
+            : createPath(location) === createPath(path);
 
         navigate(to, { replace, state, resetScroll });
       }