fix: fix encoding/matching issues with special chars (#9477)

* fix: fix encoding/matching issues with special chars * add changeset * Bump bundle
remix-run · Oct 21, 2022 · 80d5844 · 80d5844
1 parent 8f684eb
commit 80d5844
Show file tree

Hide file tree

Showing 6 changed files with 759 additions and 4 deletions.
diff --git a/.changeset/hot-badgers-grow.md b/.changeset/hot-badgers-grow.md
@@ -0,0 +1,6 @@
+---
+"react-router-dom": patch
+"@remix-run/router": patch
+---
+
+fix encoding/matching issues with special chars
diff --git a/packages/react-router-dom/__tests__/navigate-encode-params-test.tsx b/packages/react-router-dom/__tests__/navigate-encode-params-test.tsx
@@ -12,6 +12,7 @@ import {
 describe("navigate with params", () => {
   let node: HTMLDivElement;
   beforeEach(() => {
+    global.history.pushState({}, "", "/");
     node = document.createElement("div");
     document.body.appendChild(node);
   });
@@ -88,7 +89,8 @@ describe("navigate with params", () => {
       let pathname = window.location.pathname.replace(/%20/g, "+");
       expect(pathname).toEqual("/blog/react+router");
 
-      expect(node.innerHTML).toMatch(/react router/);
+      // Note decodeURIComponent doesn't decode +
+      expect(node.innerHTML).toMatch(/react\+router/);
     });
   });
 });