Fix: respect the replace prop if it is defined #8779
Conversation
|
Hi @williamsdyyz, Welcome, and thank you for contributing to React Router! Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once. You may review the CLA and sign it by adding your name to contributors.yml. Once the CLA is signed, the If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run. Thanks! - The Remix team |
|
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
|
Not wanting to be needy here, but I submitted this two months ago and....nothing. Not even a comment. RR6 is causing me major issues due to bugs and breaking changes, it would be appreciated if the RR6 team focused on fixes to stabilize the current functionality before adding even more new features |
|
I requested some reviews for you now. |
|
It looks this has some conflicts with the |
| @@ -63,4 +63,6 @@ | |||
| - turansky | |||
| - underager | |||
| - vijaypushkin | |||
| - rtmann | |||
There was a problem hiding this comment.
^^ I don't think this is intentional - potentially leftover from the merge conflict resolution?
There was a problem hiding this comment.
Sorry. It got sorted not added.
This is a fix for #8777