Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: treat absolute/same-origin/different-basename <Link to> values as external #10135

Merged
merged 4 commits into from Feb 23, 2023
Merged

fix: treat absolute/same-origin/different-basename <Link to> values as external #10135

merged 4 commits into from Feb 23, 2023

Conversation

brophdawg11
Copy link
Contributor

Closes #10052

@changeset-bot
Copy link

changeset-bot bot commented Feb 23, 2023 •
edited

🦋 Changeset detected

Latest commit: 9f5fdb0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
react-router-dom Patch
react-router Patch
react-router-dom-v5-compat Patch
react-router-native Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@brophdawg11 brophdawg11 linked an issue Feb 23, 2023 that may be closed by this pull request
[Bug]: absolute redirect fails while using base url #10052
Closed
brophdawg11
brophdawg11 commented Feb 23, 2023
View reviewed changes
packages/react-router-dom/__tests__/link-click-test.tsx
@@ -138,7 +138,6 @@ describe("A <Link> click", () => {
<div>
<h1>Home</h1>
<Link
reloadDocument
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't have this on this Link since the external URL should be what forces it to behave as a full-document link click

brophdawg11
brophdawg11 commented Feb 23, 2023
View reviewed changes
packages/react-router-dom/index.tsx

if (targetUrl.origin === currentUrl.origin && path != null) {
// Strip the protocol/origin/basename for same-origin absolute URLs
to = path + targetUrl.search + targetUrl.hash;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Must have the same basename to be considered "internal" (stripBasename returns null if it doesn't). And then we should provide the to without a basename to useHref which will prepend it back on

@brophdawg11 brophdawg11 merged commit d43e1ab into release-next Feb 23, 2023
@brophdawg11 brophdawg11 deleted the brophdawg11/link-absolute-basename branch February 23, 2023 19:22
@mcansh mcansh mentioned this pull request Feb 23, 2023
Merged
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 6.8.2-pre.3 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@mcansh mcansh mentioned this pull request Feb 27, 2023
Merged
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 6.8.2 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcansh mcansh mcansh approved these changes

@jacob-ebey jacob-ebey jacob-ebey approved these changes

Assignees
No one assigned
Labels
CLA Signed react-router-dom
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: absolute redirect fails while using base url
4 participants
@brophdawg11 @mcansh @jacob-ebey @MichaelDeBoey