fix(react-router): remove double navigation of Navigation component in StrictMode

[alex3d]

No description provided.

[remix-cla-bot]

Hi @alex3d,

Welcome, and thank you for contributing to React Router!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run.

Thanks!

- The Remix team

[changeset-bot]

⚠️ No Changeset found

Latest commit: 0980e86

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[remix-cla-bot]

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

[alex3d]

This could probably be removed after navigateCalledRef was added.
No tests fails with this statement removed.

[brophdawg11]

This is error-prone since if the component doesn't unmount the ref will stay true forever even if the to changes. I left a comment on #10217 about <Navigate to={-1}> being an invalid use-case, and we've made some minor updates to the internals of Navigate in #10435 to better comply with StrictMode expectations, so I'm going to close this out.