Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update window.history before setting updated React state on navigations #10448

Merged
merged 3 commits into from Jun 2, 2023

Conversation

holynewbie
Copy link
Contributor

fix #10446

@changeset-bot
Copy link

changeset-bot bot commented May 4, 2023

🦋 Changeset detected

Latest commit: 88e4248

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@remix-run/router Patch
react-router-dom Patch
react-router Patch
react-router-dom-v5-compat Patch
react-router-native Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented May 4, 2023

Hi @holynewbie,

Welcome, and thank you for contributing to React Router!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run.

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented May 4, 2023

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@brophdawg11 brophdawg11 changed the title fix #10446 Update window.history before setting updated React state on navigations May 4, 2023
contributors.yml Outdated Show resolved Hide resolved
@brophdawg11
Copy link
Contributor

Gonna merge this but please see the comment on the linked issue for a warning about relying on window.location :)

This just missed the release branch for 6.12.0, so it should be available in the next release - likely 6.12.1 or 6.13.0

@brophdawg11 brophdawg11 merged commit 2bf0fe9 into remix-run:dev Jun 2, 2023
2 checks passed
@brophdawg11
Copy link
Contributor

Thanks for the PR @holynewbie!

@brophdawg11 brophdawg11 added awaiting release This issue have been fixed and will be released soon and removed awaiting release This issue have been fixed and will be released soon labels Jun 2, 2023
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 6.14.0-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 6.14.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants