Fix elementId not decoded when emulate native hash scroll #10642
Conversation
🦋 Changeset detectedLatest commit: e4f83b4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Hi @istarkov, Welcome, and thank you for contributing to React Router! Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once. You may review the CLA and sign it by adding your name to contributors.yml. Once the CLA is signed, the If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run. Thanks! - The Remix team |
|
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
|
Size checks ;) |
## Description closes #1824 - [x] single edgecase left if id is equal to `hello%20world` nothing works - [x] fix back button cause chrome bug https://discord.com/channels/955905230107738152/1122839004375691355 - [x] allow edit form in preview mode to close issue above Fix corresponding issue in RR remix-run/react-router#10642 At SaaS patched too ## Steps for reproduction create links on pages with anchor <img width="254" alt="image" src="https://github.com/webstudio-is/webstudio-builder/assets/5077042/46a880f3-cdd0-4e19-8cb4-b608bdc4f96a"> Check it works ## Code Review - [ ] hi @kof, I need you to do - conceptual review (architecture, feature-correctness) - detailed review (read every line) - test it on preview ## Before requesting a review - [ ] made a self-review - [ ] added inline comments where things may be not obvious (the "why", not "what") ## Before merging - [ ] tested locally and on preview environment (preview dev login: 5de6) - [ ] updated [test cases](https://github.com/webstudio-is/webstudio-builder/blob/main/apps/builder/docs/test-cases.md) document - [ ] added tests - [ ] if any new env variables are added, added them to `.env.example` and the `builder/env-check.js` if mandatory --------- Co-authored-by: Oleg Isonen <oleg008@gmail.com>
|
Thank you! I didn't have push rights to the source repo here so to make changes to the changeset I cherry-picked these commits into #10682. |
closes #10641