Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(react-router-dom): Fix usePrompt invalid blocker state transition #10687

Merged
merged 5 commits into from
Jul 13, 2023
Merged

fix(react-router-dom): Fix usePrompt invalid blocker state transition #10687

merged 5 commits into from
Jul 13, 2023

Commits on Jul 11, 2023

  1. fix(react-router-dom): Fix usePrompt invalid blocker state transition 

    - Remove the `setTimeout` wrapping `blocker.proceed`. This defers the execution of the function, but I don't think that's what we want here.
- Reorder the `useEffect`s so that we attempt to proceed first when appropriate and prevent resetting a blocker that we're about to proceed.
    @louis-young
    louis-young committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    48df1b1 View commit details
    Browse the repository at this point in the history

  2. chore(CLA): Sign CLA

    @louis-young
    louis-young committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    c4c96cf View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2023

  1. test(usePrompt): Write unit test suite

    @louis-young
    louis-young committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    9d708b5 View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2023

  1. Update tests

    @brophdawg11
    brophdawg11 committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    d470e99 View commit details
    Browse the repository at this point in the history

  2. Add changeset

    @brophdawg11
    brophdawg11 committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    9c14068 View commit details
    Browse the repository at this point in the history