Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: export PathParam type #10719

Merged
merged 1 commit into from Nov 16, 2023
Merged

feat: export PathParam type #10719

merged 1 commit into from Nov 16, 2023

Conversation

jonkoops
Copy link
Contributor

Exports the PathParam type from the package, so it can be used by consumers. I personally found the need for this, as I have some code in my project that builds on top of generatePath(), and thus I need to also be able to use the same types it uses internally.

@changeset-bot
Copy link

changeset-bot bot commented Jul 19, 2023 •
edited

🦋 Changeset detected

Latest commit: c2d5c0e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
react-router-dom-v5-compat Minor
react-router-native Minor
react-router-dom Minor
react-router Minor
@remix-run/router Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jonkoops
Copy link
Contributor Author

jonkoops commented Oct 3, 2023

@mjackson @ryanflorence @brophdawg11 would it be possible to get this reviewed? It's a very small change, but it would help us out a lot.

@jonkoops
Copy link
Contributor Author

jonkoops commented Oct 3, 2023

For an in the wild use-case of this see keycloak/keycloak#23667

@jonkoops
Copy link
Contributor Author

@timdorr @MichaelDeBoey sorry to call you out like this, but could one of you help me move this forward?

brophdawg11
brophdawg11 approved these changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@brophdawg11 brophdawg11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Sorry for the delay!

@brophdawg11 brophdawg11 merged commit a48c43c into remix-run:dev Nov 16, 2023
3 checks passed
@jonkoops
Copy link
Contributor Author

No problem, thanks for landing this!

@jonkoops jonkoops deleted the export-path-param-type branch November 16, 2023 20:43
@github-actions github-actions bot mentioned this pull request Nov 21, 2023
Merged
@github-actions GitHub Actions
Copy link
Contributor

🤖 Hello there,

We just published version 6.20.0-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions github-actions bot mentioned this pull request Nov 22, 2023
Merged
@github-actions GitHub Actions
Copy link
Contributor

🤖 Hello there,

We just published version 6.20.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

jonathanpruvost pushed a commit to concordnow/react-router that referenced this pull request Nov 28, 2023
@jonkoops @jonathanpruvost
feat: export PathParam type (remix-run#10719)
07a36b8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brophdawg11 brophdawg11 brophdawg11 approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonkoops @brophdawg11