Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docs on NavLink w.r.t. links to the root route and the end prop #10757

Merged
merged 2 commits into from Aug 2, 2023

Conversation

brophdawg11
Copy link
Contributor

Clear up NavLink docs confusion on root (/) links and the end prop from #9261 (comment). I think the docs were always wrong since before 6.4 this was the behavior, it briefly changed in 6.4.0->6.4.2 until we reverted the underlying change to NavLink's internals.

See #9497 (comment)

@changeset-bot
Copy link

changeset-bot bot commented Aug 2, 2023

⚠️ No Changeset found

Latest commit: fd65cdd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@brophdawg11 brophdawg11 merged commit b23d7b5 into main Aug 2, 2023
3 checks passed
@brophdawg11 brophdawg11 deleted the brophdawg11/nav-link-root-path-docs branch August 2, 2023 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant