Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize and document useBlocker #10991

Merged
merged 3 commits into from Nov 3, 2023
Merged

Conversation

brophdawg11
Copy link
Contributor

No description provided.

Copy link

changeset-bot bot commented Nov 2, 2023

🦋 Changeset detected

Latest commit: 5243d88

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
react-router Minor
react-router-dom Minor
react-router-dom-v5-compat Minor
react-router-native Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@brophdawg11 brophdawg11 merged commit 4f6c454 into dev Nov 3, 2023
3 checks passed
@brophdawg11 brophdawg11 deleted the brophdawg11/stabilize-use-blocker branch November 3, 2023 14:39
Copy link
Contributor

🤖 Hello there,

We just published version 6.19.0-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Copy link
Contributor

🤖 Hello there,

We just published version 6.19.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

dennisoelkers added a commit to Graylog2/graylog2-server that referenced this pull request Nov 22, 2023
jonathanpruvost pushed a commit to concordnow/react-router that referenced this pull request Nov 28, 2023
@gidomanders
Copy link

Why is the Blocker type still exported as unsafe_Blocker? Can the unsafe_ prefix also be removed from that type?

@timdorr
Copy link
Member

timdorr commented Jan 11, 2024

It's not:

export type Blocker = BlockerUnblocked | BlockerBlocked | BlockerProceeding;

@gidomanders
Copy link

@timdorr then why do I get this when I try to import Blocker?

Screenshot 2024-01-12 at 13 09 16

@brophdawg11
Copy link
Contributor Author

Looks like we missed the types - addressed in #11187

dennisoelkers added a commit to Graylog2/graylog2-server that referenced this pull request Feb 13, 2024
…e/packages/graylog-web-plugin (#17358)

* Bump react-router-dom

Bumps [react-router-dom](https://github.com/remix-run/react-router/tree/HEAD/packages/react-router-dom) from 6.18.0 to 6.19.0.
- [Release notes](https://github.com/remix-run/react-router/releases)
- [Changelog](https://github.com/remix-run/react-router/blob/main/packages/react-router-dom/CHANGELOG.md)
- [Commits](https://github.com/remix-run/react-router/commits/react-router-dom@6.19.0/packages/react-router-dom)

---
updated-dependencies:
- dependency-name: react-router-dom
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* Removing `unstable_` prefix (remix-run/react-router#10991)

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Dennis Oelkers <dennis@graylog.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants