Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch errors when trying to unwrap responses #11061

Merged
merged 1 commit into from Dec 4, 2023

Conversation

brophdawg11
Copy link
Contributor

Closes #11055

@brophdawg11 brophdawg11 linked an issue Nov 27, 2023 that may be closed by this pull request
Copy link

changeset-bot bot commented Nov 27, 2023

🦋 Changeset detected

Latest commit: e79d5ef

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@remix-run/router Patch
react-router Patch
react-router-dom Patch
react-router-dom-v5-compat Patch
react-router-native Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vyrotek
Copy link

vyrotek commented Nov 28, 2023

Thanks for this!

This seems like it should work around an issue we're seeing where our fetch response text/json stream has already been read by our 3rd party API library but the router is trying to read the stream again when an error is caught.

@brophdawg11 brophdawg11 merged commit dc7833c into dev Dec 4, 2023
3 checks passed
@brophdawg11 brophdawg11 deleted the brophdawg11/catch-unwrap-error branch December 4, 2023 22:48
Copy link
Contributor

github-actions bot commented Dec 5, 2023

🤖 Hello there,

We just published version 6.21.0-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Copy link
Contributor

🤖 Hello there,

We just published version 6.21.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Unhandled error when throwing read responses
2 participants