New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix router re-initialization bug #11301
base: dev
Are you sure you want to change the base?
Conversation
|
Hi @steinybot, Welcome, and thank you for contributing to React Router! Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once. You may review the CLA and sign it by adding your name to contributors.yml. Once the CLA is signed, the If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run. Thanks! - The Remix team |
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
Not sure what the deal is about updating react-router-dom. Do I need to make the same change there? |
7df4b5d
to
ab94afd
Compare
ab94afd
to
7c95128
Compare
const wasRouterPreviouslyInitialized = useRef(false); | ||
const isRouterInitialized = router.state.initialized; | ||
const routerReinitializing = | ||
wasRouterPreviouslyInitialized && !isRouterInitialized; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Drive-by comment - this looks like a typo?
wasRouterPreviouslyInitialized && !isRouterInitialized; | |
wasRouterPreviouslyInitialized.current && !isRouterInitialized; |
Fixes #11300