Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V7 rename #11403

Merged
merged 5 commits into from
Apr 10, 2024
Merged

V7 rename #11403

merged 5 commits into from
Apr 10, 2024

Conversation

jacob-ebey
Copy link
Member

No description provided.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 3, 2024 •
edited

⚠️ No Changeset found

Latest commit: 4698b9f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jacob-ebey jacob-ebey force-pushed the v7_rename branch 3 times, most recently from 0094568 to e5c4fdd Compare April 9, 2024 18:50
brophdawg11
brophdawg11 reviewed Apr 10, 2024
View reviewed changes
integration/helpers/cf-template/app/root.tsx
import type { LinksFunction } from "@remix-run/cloudflare";
import { cssBundleHref } from "@remix-run/css-bundle";
import type { LinksFunction } from "@react-router/cloudflare";
import { cssBundleHref } from "@react-router/css-bundle";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the css-bundle package is obsolete in a vite-only world?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a few loose ends like this lying around, so I think we can merge this as-is for now and do a broader cleanup as a separate pass.

brophdawg11
brophdawg11 reviewed Apr 10, 2024
View reviewed changes
sgconfig.yml Outdated Show resolved Hide resolved
@markdalgleish
Copy link
Member

The Windows test failure is unrelated to this PR, this just happens to be the first PR touching the dev package since adding cross-browser integration tests. We can ignore that test failure for now and solve it in a separate PR.

@markdalgleish markdalgleish merged commit c0cc242 into v7 Apr 10, 2024
5 of 8 checks passed
@markdalgleish markdalgleish deleted the v7_rename branch April 10, 2024 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brophdawg11 brophdawg11 brophdawg11 left review comments

@markdalgleish markdalgleish markdalgleish approved these changes

@pcattori pcattori pcattori approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jacob-ebey @markdalgleish @pcattori @brophdawg11