Add additional props passing method #3389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| - Pass in a `render` handler to `<Router>` with the result of `applyRouterMiddleware`, using a middleware such as: | ||
| ```javascript | ||
| () => ({ | ||
| renderRouteComponent: (child, routeComponentProps) => React.cloneElement(child, extraProps) |
There was a problem hiding this comment.
extraProps => ({
renderRouteComponent: child => React.cloneElement(child, extraProps)
})
|
Maybe it's a good idea to mention that you can access the |
|
That can be covered in other docs. It's not relevant for the purposes of this discussion and will e.g. fail most linting rules. |
| - Pass in a `render` handler to `<Router>` with the result of `applyRouterMiddleware`, using a middleware such as: | ||
| ```javascript | ||
| extraProps => ({ | ||
| renderRouteComponent: (child, routeComponentProps) => React.cloneElement(child, extraProps) |
There was a problem hiding this comment.
Please drop routeComponentProps here.
This solution is an improvement over the `createElement` method in that it passes eslint-plugin-react problem jsx-eslint/eslint-plugin-react#512, and that conceptually, I think a middleware is the place to do these kind of manipulations.
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solution is an improvement over the
createElementmethod in that it passes eslint-plugin-react problem jsx-eslint/eslint-plugin-react#512, and that conceptually, I think a middleware is the place to do these kind of manipulations.