update readme to clarify pathname

[kellyrmilligan]

I thought this might help clarify the parameters of matchRoutes.

[pshrmn]

Strictly speaking, this isn't a Node urlObject.pathname. The linked document specifies that a urlObject.pathname is not decoded, but the pathname provided to matchRoutes should be decoded. If it was not, then routes would not work with unicode characters. history automatically decodes the pathname when creating location objects.

I'm not sure if the best fix would be to change the link or just specify that the pathname should be decoded, but I think that it is a point worth clarifying.

[pshrmn]

The blank line at the end is intentional (for git).

[kellyrmilligan]

@pshrmn good point. is the link I added instead any good? I tried to do both 😄

[kellyrmilligan]

Also, do you happen to know where history does this decoding? I am calling react router config in node with the path from hapi and it's the pathname in node so as you pointed out is not decoded

[pshrmn]

history does the decoding in parsePath, but I think that is going to be moved to createLocation. There is an issue with history right now because when I added automatic decoding, I also added automatic encoding. Unfortunately, that results in double encoding if someone pre-encodes their pathname. You can check remix-run/history/pull/465 for more information

I'm not actually particularly sure how react-router-config would work on the server because I don't use the package. You are creating a memory history at some point, right? I would use the location object generated by that.

const history = createMemoryHistory({ initialEntries: [request.path] })
const { pathname } = history.location
const branch = matchRoutes(routes, pathname)

[kellyrmilligan]

@pshrmn i'm using static router per the new rr4 docs recommendation. I can send that path without decoding as you mentioned it auto decodes it right? anyway, here's the repo where i'm upgrading it to use RR4 and react-router-config for backend use:

https://github.com/kellyrmilligan/hapi-react-redux/tree/rr4upgrade

the readme on this branch needs updating, but the api of the hapi plugin is roughly the same.

[pshrmn]

The <StaticRouter> module includes its own createLocation function that calls parsePath (which currently decodes). There will probably end up being an issue with that if/when decodeURI gets moved to createLocation.

[kellyrmilligan]

I just went with decodeUri in the module due to the flow of the rendering/data fetching I'm doing

[timdorr]

Not sure how this got missed, since it's easy peasy.