Adds failing test cases for Issue 5296 #5359
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbenson-wikia
changed the title
timdorr
force-pushed
the
master
branch
2 times, most recently
from
fb3a586
to
f9481bb
Compare
|
This should be fixed by #5722, but if you want to rebase against |
timdorr
force-pushed
the
master
branch
4 times, most recently
from
8f33936
to
1fb8696
Compare
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5296
Primarily, this test suite PR demonstrates inconsistencies in path matching depending on context (
matchParams,StaticRouter, andRouterat a minimum). It is suggested that all path matching logic be consolidated into a single place to avoid this sort of problem.Additional test cases were also added to cover some potentially tricky use cases I thought up while I was in there.