Hoist dependencies = smaller react-router-dom UMD #5720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, react-router-dom's UMD builds contained duplicate code because they were fetching from both `packages/react-router/node-modules` and `packages/react-router-dom/node_modules`. With hoisting, this build is now fetching from the root `node_modules`.
|
The website isn't playing well with this right now, so I'll need to try to figure out what is going on with that before this can be merged. |
|
OK, I think it's fixed. But there's a big internal dep on this copypasta-ed |
|
I'm going to merge this in so we can close out #5718. Removing the Animated module is something we can take care of later. |
|
BTW, we saved even more bytes from #5589, which I merged in before this: # Before
93807 packages/react-router/umd/react-router.js
24574 packages/react-router/umd/react-router.min.js
179362 packages/react-router-dom/umd/react-router-dom.js
51512 packages/react-router-dom/umd/react-router-dom.min.js
# After
88063 packages/react-router/umd/react-router.js
19341 packages/react-router/umd/react-router.min.js
124601 packages/react-router-dom/umd/react-router-dom.js
29537 packages/react-router-dom/umd/react-router-dom.min.js |
|
maintainer, all i want for christmas is yoouuur release with smaller size. thanks and merry christmas! |
bors bot
added a commit
to mozilla/delivery-console
that referenced
this pull request
Jun 6, 2018
179: Update dependency react-router-dom to v4.3.0 r=magopian a=renovate[bot] This Pull Request updates dependency [react-router-dom](https://github.com/ReactTraining/react-router) from `v4.2.2` to `v4.3.0` <details> <summary>Release Notes</summary> ### [`v4.3.0`](https://github.com/ReactTraining/react-router/blob/master/CHANGELOG.md#v430httpsgithubcomReactTrainingreact-routercomparev420v430) [Compare Source](remix-run/react-router@v4.3.0-rc.3...a27bc56) > Jun 6, 2018 * Use the `pretty` option in generatePath ([#​6172] by @​sibelius) * aria-current has incorrect value "true" ([#​6118] by @​brandonrninefive) * Redirect with parameters ([#​5209] by @​dlindenkreuz) * Fix with missing pathname: `<Link to="?foo=bar">` ([#​5489] by @​pshrmn) * Escape NavLink path to allow special characters in path. ([#​5596] by @​esiegel) * Expose `generatePath` ([#​5661] by @​rybon) * Use named import of history module. ([#​5589] by @​RoboBurned) * Hoist dependencies for smaller UMD builds ([#​5720] by @​pshrmn) * Remove aria-current from navLink when inactive ([#​5508] by @​AlmeroSteyn) * Add invariant for missing "to" property on `<Link>` ([#​5792] by @​selbekk) * Use Prettier on the code ([e6f9017] by @​mjackson) * Fix pathless route's match when parent is null ([#​5964] by @​pshrmn) * Use history.createLocation in `<StaticRouter>` ([#​5722] by @​pshrmn) [#​6172]: `remix-run/react-router#6172 [#​6118]: `remix-run/react-router#6118 [#​5209]: `remix-run/react-router#5209 [#​5489]: `remix-run/react-router#5489 [#​5596]: `remix-run/react-router#5596 [#​5661]: `remix-run/react-router#5661 [#​5589]: `remix-run/react-router#5589 [#​5720]: `remix-run/react-router#5720 [#​5508]: `remix-run/react-router#5508 [#​5792]: `remix-run/react-router#5792 [e6f9017]: remix-run/react-router@e6f9017 [#​5964]: `remix-run/react-router#5964 [#​5722]: `remix-run/react-router#5722 --- ### [`v4.3.0-rc.3`](https://github.com/ReactTraining/react-router/releases/v4.3.0-rc.3) [Compare Source](remix-run/react-router@v4.3.0-rc.2...v4.3.0-rc.3) - Fix broken UMD builds. - Add sideEffects: false for webpack tree shaking (#​6082 by @​taylorc93) --- ### [`v4.3.0-rc.2`](https://github.com/ReactTraining/react-router/releases/v4.3.0-rc.2) [Compare Source](remix-run/react-router@v4.3.0-rc.1...v4.3.0-rc.2) - Bump `hoist-non-react-statics` for React 16.3. - Missing `generatePath` in `react-router-dom` package. --- ### [`v4.3.0-rc.1`](https://github.com/ReactTraining/react-router/releases/v4.3.0-rc.1) [Compare Source](remix-run/react-router@v4.2.2...v4.3.0-rc.1) > Mar 26, 2018 - Redirect with parameters ([#​5209] by @​dlindenkreuz) - Fix with missing pathname: `<Link to="?foo=bar">` ([#​5489] by @​pshrmn) - Escape NavLink path to allow special characters in path. ([#​5596] by @​esiegel) - Expose `generatePath` ([#​5661] by @​rybon) - Use named import of history module. ([#​5589] by @​RoboBurned) - Hoist dependencies for smaller UMD builds ([#​5720] by @​pshrmn) - Remove aria-current from navLink when inactive ([#​5508] by @​AlmeroSteyn) - Add invariant for missing "to" property on `<Link>` ([#​5792] by @​selbekk) - Use Prettier on the code ([e6f9017] by @​mjackson) - Fix pathless route's match when parent is null ([#​5964] by @​pshrmn) - Use history.createLocation in `<StaticRouter>` ([#​5722] by @​pshrmn) [#​5209]: `remix-run/react-router#5209 [#​5489]: `remix-run/react-router#5489 [#​5596]: `remix-run/react-router#5596 [#​5661]: `remix-run/react-router#5661 [#​5589]: `remix-run/react-router#5589 [#​5720]: `remix-run/react-router#5720 [#​5508]: `remix-run/react-router#5508 [#​5792]: `remix-run/react-router#5792 [e6f9017]: remix-run/react-router@e6f9017 [#​5964]: `remix-run/react-router#5964 [#​5722]: `remix-run/react-router#5722 --- </details> --- This PR has been generated by [Renovate Bot](https://renovatebot.com). Co-authored-by: Renovate Bot <bot@renovateapp.com>
bors bot
added a commit
to mozilla/delivery-console
that referenced
this pull request
Jun 6, 2018
178: Update dependency react-router to v4.3.0 r=magopian a=renovate[bot] This Pull Request updates dependency [react-router](https://github.com/ReactTraining/react-router) from `v4.2.0` to `v4.3.0` <details> <summary>Release Notes</summary> ### [`v4.3.0`](https://github.com/ReactTraining/react-router/blob/master/CHANGELOG.md#v430httpsgithubcomReactTrainingreact-routercomparev420v430) [Compare Source](remix-run/react-router@v4.3.0-rc.3...v4.3.0) > Jun 6, 2018 * Use the `pretty` option in generatePath ([#​6172] by @​sibelius) * aria-current has incorrect value "true" ([#​6118] by @​brandonrninefive) * Redirect with parameters ([#​5209] by @​dlindenkreuz) * Fix with missing pathname: `<Link to="?foo=bar">` ([#​5489] by @​pshrmn) * Escape NavLink path to allow special characters in path. ([#​5596] by @​esiegel) * Expose `generatePath` ([#​5661] by @​rybon) * Use named import of history module. ([#​5589] by @​RoboBurned) * Hoist dependencies for smaller UMD builds ([#​5720] by @​pshrmn) * Remove aria-current from navLink when inactive ([#​5508] by @​AlmeroSteyn) * Add invariant for missing "to" property on `<Link>` ([#​5792] by @​selbekk) * Use Prettier on the code ([e6f9017] by @​mjackson) * Fix pathless route's match when parent is null ([#​5964] by @​pshrmn) * Use history.createLocation in `<StaticRouter>` ([#​5722] by @​pshrmn) [#​6172]: `remix-run/react-router#6172 [#​6118]: `remix-run/react-router#6118 [#​5209]: `remix-run/react-router#5209 [#​5489]: `remix-run/react-router#5489 [#​5596]: `remix-run/react-router#5596 [#​5661]: `remix-run/react-router#5661 [#​5589]: `remix-run/react-router#5589 [#​5720]: `remix-run/react-router#5720 [#​5508]: `remix-run/react-router#5508 [#​5792]: `remix-run/react-router#5792 [e6f9017]: remix-run/react-router@e6f9017 [#​5964]: `remix-run/react-router#5964 [#​5722]: `remix-run/react-router#5722 --- ### [`v4.3.0-rc.3`](https://github.com/ReactTraining/react-router/releases/v4.3.0-rc.3) [Compare Source](remix-run/react-router@v4.3.0-rc.2...v4.3.0-rc.3) - Fix broken UMD builds. - Add sideEffects: false for webpack tree shaking (#​6082 by @​taylorc93) --- ### [`v4.3.0-rc.2`](https://github.com/ReactTraining/react-router/releases/v4.3.0-rc.2) [Compare Source](remix-run/react-router@v4.3.0-rc.1...v4.3.0-rc.2) - Bump `hoist-non-react-statics` for React 16.3. - Missing `generatePath` in `react-router-dom` package. --- ### [`v4.3.0-rc.1`](https://github.com/ReactTraining/react-router/releases/v4.3.0-rc.1) [Compare Source](remix-run/react-router@v4.2.0...v4.3.0-rc.1) > Mar 26, 2018 - Redirect with parameters ([#​5209] by @​dlindenkreuz) - Fix with missing pathname: `<Link to="?foo=bar">` ([#​5489] by @​pshrmn) - Escape NavLink path to allow special characters in path. ([#​5596] by @​esiegel) - Expose `generatePath` ([#​5661] by @​rybon) - Use named import of history module. ([#​5589] by @​RoboBurned) - Hoist dependencies for smaller UMD builds ([#​5720] by @​pshrmn) - Remove aria-current from navLink when inactive ([#​5508] by @​AlmeroSteyn) - Add invariant for missing "to" property on `<Link>` ([#​5792] by @​selbekk) - Use Prettier on the code ([e6f9017] by @​mjackson) - Fix pathless route's match when parent is null ([#​5964] by @​pshrmn) - Use history.createLocation in `<StaticRouter>` ([#​5722] by @​pshrmn) [#​5209]: `remix-run/react-router#5209 [#​5489]: `remix-run/react-router#5489 [#​5596]: `remix-run/react-router#5596 [#​5661]: `remix-run/react-router#5661 [#​5589]: `remix-run/react-router#5589 [#​5720]: `remix-run/react-router#5720 [#​5508]: `remix-run/react-router#5508 [#​5792]: `remix-run/react-router#5792 [e6f9017]: remix-run/react-router@e6f9017 [#​5964]: `remix-run/react-router#5964 [#​5722]: `remix-run/react-router#5722 --- </details> --- This PR has been generated by [Renovate Bot](https://renovatebot.com). Co-authored-by: Renovate Bot <bot@renovateapp.com>
jeresig
pushed a commit
to Khan/react-router
that referenced
this pull request
Aug 29, 2018
* Hoist dependencies = smaller react-router-dom UMD Previously, react-router-dom's UMD builds contained duplicate code because they were fetching from both `packages/react-router/node-modules` and `packages/react-router-dom/node_modules`. With hoisting, this build is now fetching from the root `node_modules`. * eslint --fix the website. * Update and sync packages. * Fix website for React 16 * De-hoist RRN's react dep
This was referenced Sep 22, 2018
Open
This was referenced Sep 23, 2018
This was referenced Oct 26, 2018
This was referenced Nov 23, 2018
1 task
1 task
1 task
This was referenced Jan 7, 2019
Closed
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, react-router-dom's UMD builds contained duplicate code because they were fetching from both
packages/react-router/node-modulesandpackages/react-router-dom/node_modules. With hoisting, this build is now fetching from the rootnode_modules.I don't think that the changes to the
react-router-dom/rollup.config.jsare actually necessary since rollup will try to resolve from a parentnode_modules, but I wanted to be explicit about that.Fixes #5718.