Used named imports for react-router in react-router-config #6291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was recently doing some bundle size analysis using source-map-explorer and noticed that we had a little bit of duplication of react-router code. It seems as though our import of react-router-config was bringing in modules from react-router/Foo, while our named imports from react-router was bringing in modules from react-router/es/Foo. As a workaround, I've set up a webpack alias to avoid the duplication, but I think this should be solved in this package so that everyone can benefit. I believe this is similar to: - remix-run#5589
itsmichaeldiego
approved these changes
Aug 23, 2018
|
Thanks! |
jeresig
pushed a commit
to Khan/react-router
that referenced
this pull request
Aug 29, 2018
…#6291) I was recently doing some bundle size analysis using source-map-explorer and noticed that we had a little bit of duplication of react-router code. It seems as though our import of react-router-config was bringing in modules from react-router/Foo, while our named imports from react-router was bringing in modules from react-router/es/Foo. As a workaround, I've set up a webpack alias to avoid the duplication, but I think this should be solved in this package so that everyone can benefit. I believe this is similar to: - remix-run#5589
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was recently doing some bundle size analysis using source-map-explorer
and noticed that we had a little bit of duplication of react-router
code. It seems as though our import of react-router-config was bringing
in modules from react-router/Foo, while our named imports from
react-router was bringing in modules from react-router/es/Foo.
As a workaround, I've set up a webpack alias to avoid the duplication,
but I think this should be solved in this package so that everyone can
benefit.
I believe this is similar to: