Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added react-is to validate the proptype for Route's component. #6417

Merged
merged 4 commits into from Oct 26, 2018
Merged

Added react-is to validate the proptype for Route's component. #6417

merged 4 commits into from Oct 26, 2018

Commits on Oct 23, 2018

  1. Added react-is to validate the proptype for Route's component. 

    Removed a couple of outdated TODOs that dealt with __DEV__

The rest of the changes were done just from an npm install command

React-is does add a tiny bit of size ( https://bundlephobia.com/result?p=react-is@16.5.2 ) as noted by the snapshots, but it seems like the best (and official) way to support the check.
    Anthony Frehner committed Oct 23, 2018
    Copy the full SHA
    a4514cd View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2018

  1. Revert removal of __DEV__

    Anthony Frehner committed Oct 25, 2018
    Copy the full SHA
    accdbe3 View commit details
    Browse the repository at this point in the history

  2. Updated the error message to be a little more clear about which prop … 

    …is invalid.
    Anthony Frehner committed Oct 25, 2018
    Copy the full SHA
    099de3b View commit details
    Browse the repository at this point in the history

  3. Realized it wasn't saying what I wanted, so I just reverted it.

    Anthony Frehner committed Oct 25, 2018
    Copy the full SHA
    04599bf View commit details
    Browse the repository at this point in the history