fix regression to allow for empty-string paths #6942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heygrady
force-pushed
the
fix-empty-string-path
branch
from
cb1151a
to
751d296
Compare
timdorr
reviewed
Sep 27, 2019
| @@ -35,7 +35,8 @@ function matchPath(pathname, options = {}) { | |||
| const paths = [].concat(path); | |||
|
|
|||
| return paths.reduce((matched, path) => { | |||
| if (!path) return null; | |||
| // https://github.com/ReactTraining/react-router/issues/6941 | |||
There was a problem hiding this comment.
Suggested change
| // https://github.com/ReactTraining/react-router/issues/6941 |
The link to this will be in their history, so this comment isn't needed.
heygrady
force-pushed
the
fix-empty-string-path
branch
from
751d296
to
6968bf1
Compare
heygrady
force-pushed
the
fix-empty-string-path
branch
from
6968bf1
to
24b95b0
Compare
|
Thanks! |
|
Thanks for getting this merged, @timdorr. I tried to push a 5.1.1 release earlier today to fix the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #6941
related #6715