Replace state on repeated Link navigations #7864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Took me only two years to fix this personal TODO in ReactRouter, but I finally did it. =] |
|
Looks good to me, thanks @guidobouman. @chaance can we get this merged and released into the next 5.x release? |
chaance
approved these changes
Aug 27, 2021
|
@guidobouman holy shit man, you did it! 🕺 4+ years tracking related issues and PRs and it's finally fixed 🎉 🥳 🍾 |
|
Oh my god @vladshcherbin, we did it! 🥲 |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Back ported this fix from v6 to v5: https://github.com/ReactTraining/react-router/blob/dev/packages/react-router-dom/index.tsx#L186-L189
To check:
Fixes: #5362