Fix(Docs): Broken links of README file in Server-side Rendering
#8372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR, @sanketshah19. These links work fine on GitHub, but they are currently pointing to the wrong place on reactrouter.com. Instead of using absolute URLs in all our README's, I'd like to fix our URL resolution on the router website so they point to the correct place. I'm not going to merge this, but I'd like to leave it open as a reminder that this needs to be fixed on the router website. When we fix it there, we'll close this. I'm assigning @chaance who worked on this feature on the router website. |
This was referenced Jan 18, 2024
fix(deps): update dependency react-router-dom to v6
graphql-boilerplates/react-fullstack-graphql#765
Open
Open
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace broken links of
README.mdfile in Server-side Rendering and Add name incontributors.ymlfile for CLA