Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typo on installation.md #8373

Merged
merged 4 commits into from Dec 6, 2021
Merged

typo on installation.md #8373

merged 4 commits into from Dec 6, 2021

Conversation

Ajayff4
Copy link
Contributor

@Ajayff4 Ajayff4 commented Nov 21, 2021

suggesting command correction for package installation.

suggesting command correction for package installation.
@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Nov 21, 2021

Hi @Ajayff4,

Welcome, and thank you for contributing to React Router!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run.

Thanks!

- The Remix team

@Ajayff4 Ajayff4 changed the base branch from main to dev November 21, 2021 19:19
@Ajayff4 Ajayff4 changed the base branch from dev to main November 21, 2021 19:20
@Ajayff4 Ajayff4 changed the title typo on README.md typo on installation.md Nov 21, 2021
@timdorr
Copy link
Member

timdorr commented Nov 22, 2021

Anyone know why the CLA bot is failing here?

@mjackson
Copy link
Member

@mcansh do you know why? Is it a casing thing? Or is it perhaps because @timdorr committed the change to the contributors.yml file instead of the OP?

@mcansh
Copy link
Collaborator

mcansh commented Nov 22, 2021

@mjackson yeah i'm pretty sure it's because @Ajayff4 didn't originally add their name in the proper casing and then @timdorr updated it (Tim hasn't signed either). I've updated the bot to be case-insensitive.

TL;DR - exactly what you said @mjackson, combination of both things

@timdorr
Copy link
Member

timdorr commented Nov 23, 2021

Do I need to sign as well, or just remove my commit?

@Ajayff4
Copy link
Contributor Author

Ajayff4 commented Dec 5, 2021

Do you need any help from me?

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Dec 6, 2021

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@timdorr
Copy link
Member

timdorr commented Dec 6, 2021

Should be good to go now. Thanks!

This was referenced Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants