Use Pick instead of Omit
#8374
Use Pick instead of Omit
#8374
Conversation
|
Hi @liuhanqu, Welcome, and thank you for contributing to React Router! Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once. You may review the CLA and sign it by adding your name to contributors.yml. Once the CLA is signed, the If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run. Thanks! - The Remix team |
|
Hey there! 👋 This repository uses the Prettier code style. You forgot to format these files in your pull request:
The Prettier installation guide is a good place to get started with formatting your code properly. ❤️ Your friendly Prettifier bot. |
liuhanqu
force-pushed
the
feature/history
branch
from
a43ddea
to
47a5c32
Compare
|
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
Co-authored-by: Tim Dorr <timdorr@users.noreply.github.com>
* Fix minor grammar in `overview.md` Possessive "its" rather than contracted "it is" * Sign CLA: add name to `contributors.yml` * Some more minor typos in `faq.md` * Did a sweep of the new docs for general grammar and typos.
Co-authored-by: Kent C. Dodds <me+github@kentcdodds.com>
|
Can you make this against the |
|
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
|
It's ok. |
|
BTW, to review the actual code change here, just look at this commit: 47a5c32 |
|
I think Ryan was OK with this, so Imma merge this. Thanks @liuhanqu! |
Pick the property that would be use in
navigator, so we can know which method can be use explicitly.