Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

failing test for bug 9392 #9396

Closed
wants to merge 3 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions contributors.yml
Expand Up @@ -19,6 +19,7 @@
- chensokheng
- chrisngobanh
- christopherchudzicki
- codeape2
- coryhouse
- cvbuelow
- david-crespo
Expand Down
45 changes: 44 additions & 1 deletion packages/react-router-dom/__tests__/link-href-test.tsx
@@ -1,6 +1,15 @@
import * as React from "react";
import * as TestRenderer from "react-test-renderer";
import { MemoryRouter, Routes, Route, Link, Outlet } from "react-router-dom";
import {
MemoryRouter,
Routes,
Route,
Link,
Outlet,
HashRouter,
createHashRouter,
RouterProvider
} from "react-router-dom";

describe("<Link> href", () => {
describe("in a static route", () => {
Expand Down Expand Up @@ -679,4 +688,38 @@ describe("<Link> href", () => {
);
});
});

describe("when using <HashRouter>", () => {
test("rendered <Link> hrefs contain #", () => {
let renderer: TestRenderer.ReactTestRenderer;
TestRenderer.act(() => {
renderer = TestRenderer.create(
<HashRouter>
<Routes>
<Route path="/" element={<Link to="/about" />} />
</Routes>
</HashRouter>
);
});
expect(renderer.root.findByType("a").props.href).toEqual("#/about");
});
});

describe("when using createHashRouter", () => {
test("rendered <Link> hrefs contain #", () => {
let renderer: TestRenderer.ReactTestRenderer;
TestRenderer.act(() => {
const router = createHashRouter([
{
path: "/",
element: <Link to="/about"/>
}
]);
renderer = TestRenderer.create(
<RouterProvider router={router}/>
);
});
expect(renderer.root.findByType("a").props.href).toEqual("#/about");
});
});
});