Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update createHref to be history-aware #9409

Merged
merged 10 commits into from Oct 17, 2022
Merged

fix: update createHref to be history-aware #9409

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
532397f
failing test for bug 9392
Oct 3, 2022
d323324
missing semicolon
Oct 3, 2022
5f22be0
CLA
Oct 3, 2022
31af3cd
fix: update createHref to be history-aware
brophdawg11 Oct 5, 2022
60553bf
Merge remote-tracking branch 'codeape2/failing-test-bug-9392' into br…
brophdawg11 Oct 6, 2022
aa98e9d
fix dup test names
brophdawg11 Oct 6, 2022
6d168bf
Merge branch 'dev' into brophdawg11/create-href-fix
brophdawg11 Oct 13, 2022
a977d6f
rename internal creteHref -> createServerHref for clarity
brophdawg11 Oct 13, 2022
b99a3a0
Remove hash-specific hrefs from shared tests
brophdawg11 Oct 13, 2022
3054115
add chngeset
brophdawg11 Oct 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/funny-hotels-repeat.md
View file
Open in desktop
@@ -0,0 +1,6 @@
---
"react-router-dom": patch
"@remix-run/router": patch
---

Fix hrefs generated for createHashRouter
1 change: 1 addition & 0 deletions contributors.yml
View file
Open in desktop
Expand Up @@ -22,6 +22,7 @@
- chrisngobanh
- christopherchudzicki
- christowiz
- codeape2
- coryhouse
- cvbuelow
- dauletbaev
Expand Down