Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(react-router-dom): add createModuleRoutes utility function #9830

Closed
wants to merge 9 commits into from
Closed

feat(react-router-dom): add createModuleRoutes utility function #9830

wants to merge 9 commits into from

Commits on Jan 7, 2023

  1. add initial createModuleRoutes() implementation

    @rossipedia
    rossipedia committed Jan 7, 2023
    Configuration menu
    Copy the full SHA
    1bb6b33 View commit details
    Browse the repository at this point in the history

  2. add name to contributors.yml

    @rossipedia
    rossipedia committed Jan 7, 2023
    Configuration menu
    Copy the full SHA
    fd46e93 View commit details
    Browse the repository at this point in the history

  3. Update packages/react-router/lib/components.tsx 

    Co-authored-by: Sergio Xalambrí <hello@sergiodxa.com>
    @rossipedia @sergiodxa
    rossipedia and sergiodxa committed Jan 7, 2023
    Configuration menu
    Copy the full SHA
    364b6be View commit details
    Browse the repository at this point in the history

  4. Apply suggestions from code review

    @rossipedia
    rossipedia committed Jan 7, 2023
    Configuration menu
    Copy the full SHA
    86b3ae3 View commit details
    Browse the repository at this point in the history

  5. fix types, export some more things

    @rossipedia
    rossipedia committed Jan 7, 2023
    Configuration menu
    Copy the full SHA
    46d44a5 View commit details
    Browse the repository at this point in the history

  6. properly handle children of non-module routes

    @rossipedia
    rossipedia committed Jan 7, 2023
    Configuration menu
    Copy the full SHA
    79f7fba View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2023

  1. move createRouteModules from react-router -> react-router-dom

    @rossipedia
    rossipedia committed Jan 8, 2023
    Configuration menu
    Copy the full SHA
    b5f88d2 View commit details
    Browse the repository at this point in the history

  2. use "in" checks to better respect developer intent

    @rossipedia
    rossipedia committed Jan 8, 2023
    Configuration menu
    Copy the full SHA
    aecdd57 View commit details
    Browse the repository at this point in the history

  3. allow for specifying exports with use property

    @rossipedia
    rossipedia committed Jan 8, 2023
    Configuration menu
    Copy the full SHA
    0ff9113 View commit details
    Browse the repository at this point in the history