Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change useScrollRestoration to use pagehide event #9945

Merged
merged 3 commits into from Jan 24, 2023

Conversation

brophdawg11
Copy link
Contributor

@brophdawg11 brophdawg11 commented Jan 19, 2023

pagehide seems to be a better cross-browser way of detecting the unload of a page. And in the case of scroll restoration there's no need to ever prompt the user so pagehide seems a better option anyway.

From https://developer.mozilla.org/en-US/docs/Web/API/Window/unload_event#usage_notes:

If you're specifically trying to detect page unload events, the pagehide event is the best option.

Screenshot 2023-01-19 at 2 07 50 PM

Screenshot 2023-01-19 at 2 06 59 PM

Closes #9463

@changeset-bot
Copy link

changeset-bot bot commented Jan 19, 2023

🦋 Changeset detected

Latest commit: 67dd17f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
react-router-dom Patch
react-router Patch
react-router-dom-v5-compat Patch
react-router-native Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

* Note: The `callback` argument should be a function created with
* `React.useCallback()`.
*/
function usePageHide(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not exported currently - but if this is indeed a better way to save off some data, maybe we should export it and make a note in the docs about the use-case difference between the two hooks?

@brophdawg11 brophdawg11 merged commit db73e94 into dev Jan 24, 2023
@brophdawg11 brophdawg11 deleted the brophdawg11/pagehide branch January 24, 2023 20:56
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 6.7.1-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 6.8.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Scroll Restoration not working on page refresh in mobile safari
3 participants