fix(remix-dev/vite): use /@fs/ path to support default server/clien…

…t entry outside of app root (#7913)

Co-authored-by: Pedro Cattori <pcattori@gmail.com>

.changeset/nasty-waves-whisper.md

@@ -0,0 +1,12 @@
+---
+"@remix-run/dev": patch
+---
+
+fix(vite): Let Vite handle serving files outside of project root via `/@fs`
+
+This fixes errors when using default client entry or server entry in a pnpm project
+where those files may be outside of the project root, but within the workspace root.
+
+By default, Vite prevents access to files outside the workspace root
+(when using workspaces) or outside of the project root (when not using
+workspaces) unless user explicitly opts into it via Vite's `server.fs.allow`.

packages/remix-dev/vite/plugin.ts

@@ -85,12 +85,13 @@ const resolveFileUrl = (
   filePath: string
 ) => {
   let relativePath = path.relative(rootDirectory, filePath);
+  let isWithinRoot =
+    !relativePath.startsWith("..") && !path.isAbsolute(relativePath);
 
-  if (relativePath.startsWith("..") || path.isAbsolute(relativePath)) {
-    throw new Error(
-      `Cannot resolve asset path "${filePath}" outside of root directory "${rootDirectory}".`
-    );
-  }
+  // Vite will prevent serving files outside of the workspace
+  // unless user explictly opts in with `server.fs.allow`
+  // https://vitejs.dev/config/server-options.html#server-fs-allow
+  if (!isWithinRoot) return `/@fs` + filePath;
 
   return `/${normalizePath(relativePath)}`;
 };