chore(deps): bump esbuild to latest (#4754)

* chore: add invariant instead of using `!`

Signed-off-by: Logan McAnsh <logan@mcan.sh>

* chore(deps): bump esbuild to latest

Signed-off-by: Logan McAnsh <logan@mcan.sh>

* Create fresh-shrimps-join.md

Signed-off-by: Logan McAnsh <logan@mcan.sh>
Co-authored-by: Pedro Cattori <pcattori@gmail.com>

.changeset/fresh-shrimps-join.md

@@ -0,0 +1,8 @@
+---
+"remix": patch
+"@remix-run/dev": patch
+---
+
+Support Typescript 4.9 features (like `satisfies`) in Remix `app/` code
+
+esbuild 0.15.13 added support for parsing TS 4.9 `satisfies`, so upgrading to esbuild 0.16.3 adds that ability to the Remix compiler

packages/remix-dev/compiler/compileBrowser.ts

@@ -16,6 +16,7 @@ import { emptyModulesPlugin } from "./plugins/emptyModulesPlugin";
 import { mdxPlugin } from "./plugins/mdx";
 import { urlImportsPlugin } from "./plugins/urlImportsPlugin";
 import { writeFileSafe } from "./utils/fs";
+import invariant from "../invariant";
 
 export type BrowserCompiler = {
   // produce ./public/build/
@@ -70,7 +71,7 @@ const createEsbuildConfig = (
     entryPoints[id] = config.routes[id].file + "?browser";
   }
 
-  let plugins = [
+  let plugins: esbuild.Plugin[] = [
     deprecatedRemixPackagePlugin(options.onWarning),
     cssFilePlugin(options),
     urlImportsPlugin(),
@@ -128,9 +129,12 @@ export const createBrowserCompiler = (
         metafile: true,
         incremental: true,
       });
-      metafile = compiler.metafile!;
+      invariant(compiler.metafile, "Expected metafile to be defined");
+      metafile = compiler.metafile;
     } else {
-      metafile = (await compiler.rebuild()).metafile!;
+      let rebuild = await compiler.rebuild();
+      invariant(rebuild.metafile, "Expected metafile to be defined");
+      metafile = rebuild.metafile;
     }
     let manifest = await createAssetsManifest(remixConfig, metafile);
     manifestChannel.write(manifest);

packages/remix-dev/package.json

@@ -32,7 +32,7 @@
     "chalk": "^4.1.2",
     "chokidar": "^3.5.1",
     "dotenv": "^16.0.0",
-    "esbuild": "0.15.12",
+    "esbuild": "0.16.3",
     "execa": "5.1.1",
     "exit-hook": "2.2.1",
     "express": "^4.17.1",