Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(blog): fix diff highlights in tutorial for getPost function #1260

Merged
merged 5 commits into from Feb 16, 2022
Merged

docs(blog): fix diff highlights in tutorial for getPost function #1260

merged 5 commits into from Feb 16, 2022

Conversation

roddds
Copy link
Contributor

@roddds roddds commented Dec 28, 2021

This bit was a little confusing to me (but also, granted, it was very late at night).

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Dec 28, 2021

Hi @roddds,

Welcome, and thank you for contributing to Remix!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run.

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Dec 28, 2021

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@roddds roddds marked this pull request as ready for review December 28, 2021 02:03
@ryanflorence ryanflorence changed the base branch from dev to main February 11, 2022 03:25
@ryanflorence ryanflorence changed the base branch from main to dev February 11, 2022 03:25
@ryanflorence
Copy link
Member

hey sorry for taking a while to get to this, you mind doing this again but branch from the main branch? Docs updates go to main because then they sync to the website. Thanks!

@ryanflorence ryanflorence added the needs-response We need a response from the original author about this issue/PR label Feb 11, 2022
Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, that was weird. Let's just remove the highlight altogether. Doesn't make sense to highlight basically the whole block. https://youtu.be/GYmHYQPaHaw?t=46 😅

Thanks!

@kentcdodds kentcdodds changed the title Fix diff highlights in tutorial for getPost function docs(blog): fix diff highlights in tutorial for getPost function Feb 16, 2022
@kentcdodds kentcdodds merged commit 7d64853 into remix-run:dev Feb 16, 2022
@roddds roddds deleted the patch-2 branch February 17, 2022 00:26
@MichaelDeBoey MichaelDeBoey removed the needs-response We need a response from the original author about this issue/PR label Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants