Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README for cloudflare workers #2003

Merged
merged 2 commits into from Feb 17, 2022
Merged

Conversation

Aprillion
Copy link
Contributor

package.json changed in 505d087#diff-6f7cb3ca3844fced66c7f07386e200620a18cdd80fcddbd2436ccce135cd51b0 => no longer possible to run both commands at the same time (they use the same port)

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Feb 17, 2022

Hi @Aprillion,

Welcome, and thank you for contributing to Remix!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run.

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Feb 17, 2022

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@jacob-ebey
Copy link
Member

Can you re-target this PR against the "dev" branch? Looks good though.

@Aprillion Aprillion changed the base branch from main to dev February 17, 2022 10:29
@Aprillion
Copy link
Contributor Author

Aprillion commented Feb 17, 2022

ooops, changing base / target branch didn't work as expected, I have to checkeout and rebase in local git, one moment please :/

package.json changed in remix-run@505d087#diff-6f7cb3ca3844fced66c7f07386e200620a18cdd80fcddbd2436ccce135cd51b0 => no longer possible to run both commands at the same time (they use the same port)
@Aprillion
Copy link
Contributor Author

Can you re-target this PR against the "dev" branch? Looks good though.

@jacob-ebey now rebased (and thanks for the fast review)

@jacob-ebey jacob-ebey merged commit d87c487 into remix-run:dev Feb 17, 2022
@Aprillion Aprillion deleted the patch-1 branch February 17, 2022 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants