Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: CSS Modules support #4852

Merged
merged 95 commits into from Jan 4, 2023
Merged

feat: CSS Modules support #4852

merged 95 commits into from Jan 4, 2023

Commits on Nov 24, 2022

  1. add initial CSS Modules integration

    @markdalgleish
    markdalgleish committed Nov 24, 2022
    6 Configuration menu
    Copy the full SHA
    8b9d1b8 View commit details
    Browse the repository at this point in the history

  2. only write CSS bundle and source map to disk

    @markdalgleish
    markdalgleish committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    4cc9f8e View commit details
    Browse the repository at this point in the history

  3. Only emit CSS from the CSS bundle build

    @markdalgleish
    markdalgleish committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    5a55f96 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'dev' into markdalgleish/css-modules

    @markdalgleish
    markdalgleish committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    72de4a3 View commit details
    Browse the repository at this point in the history

  5. bump css-bundle version

    @markdalgleish
    markdalgleish committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    fc57bae View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2022

  1. clean up CSS build output logic

    @markdalgleish
    markdalgleish committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    5d96e1c View commit details
    Browse the repository at this point in the history

  2. dispose CSS compiler in browser compiler

    @markdalgleish
    markdalgleish committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    48aaaf3 View commit details
    Browse the repository at this point in the history

  3. remove emitCss option, clean up server output

    @markdalgleish
    markdalgleish committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    9f40c89 View commit details
    Browse the repository at this point in the history

  4. make CSS Modules object type readonly

    @markdalgleish
    markdalgleish committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    83eb997 View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2022

  1. add initial CSS Modules integration test

    @markdalgleish
    markdalgleish committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    0dcd2dc View commit details
    Browse the repository at this point in the history

  2. refactor local fork of CSS Modules plugin

    @markdalgleish
    markdalgleish committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    33b09aa View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2022

  1. bundle CSS to support composes property

    @markdalgleish
    markdalgleish committed Dec 5, 2022
    Configuration menu
    Copy the full SHA
    1352cc5 View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2022

  1. put CSS Modules behind v2_cssBundle future flag

    @markdalgleish
    markdalgleish committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    ec7e32a View commit details
    Browse the repository at this point in the history

  2. Merge branch 'dev' into markdalgleish/css-modules

    @markdalgleish
    markdalgleish committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    6381250 View commit details
    Browse the repository at this point in the history

  3. update css-bundle versions

    @markdalgleish
    markdalgleish committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    b4e2168 View commit details
    Browse the repository at this point in the history

  4. rename v2_cssBundle flag to unstable_cssBundle

    @markdalgleish
    markdalgleish committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    1599d3a View commit details
    Browse the repository at this point in the history

  5. remove CSS Module entry point cache

    @markdalgleish
    markdalgleish committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    88a0761 View commit details
    Browse the repository at this point in the history

  6. inline setup and buildCssModulesJs functions

    @markdalgleish
    markdalgleish committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    f31cd7a View commit details
    Browse the repository at this point in the history

  7. remove build context, clean up path resolution

    @markdalgleish
    markdalgleish committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    600897a View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2022

  1. use esbuild's resolver in lightningcss

    @markdalgleish
    markdalgleish committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    657ef3e View commit details
    Browse the repository at this point in the history

  2. refactor CSS Modules plugin

    @markdalgleish
    markdalgleish committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    55653e7 View commit details
    Browse the repository at this point in the history

  3. upgrade lightningcss

    @markdalgleish
    markdalgleish committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    08a6f66 View commit details
    Browse the repository at this point in the history

  4. use relative path for filename

    @markdalgleish
    markdalgleish committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    d6d4d70 View commit details
    Browse the repository at this point in the history

  5. add workaround for CSS Modules hash clashes

    @markdalgleish
    markdalgleish committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    ccf946f View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2022

  1. simplify esbuild plugin, add PluginData type

    @markdalgleish
    markdalgleish committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    e63338d View commit details
    Browse the repository at this point in the history

  2. namespace compiled CSS suffix

    @markdalgleish
    markdalgleish committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    ea3e3bd View commit details
    Browse the repository at this point in the history

  3. use complete path for virtual CSS file name

    @markdalgleish
    markdalgleish committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    be03658 View commit details
    Browse the repository at this point in the history

  4. split CSS Modules test cases, add more, clean up

    @markdalgleish
    markdalgleish committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    e2c2d1a View commit details
    Browse the repository at this point in the history

  5. Merge branch 'dev' into markdalgleish/css-modules

    @markdalgleish
    markdalgleish committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    abdd5d3 View commit details
    Browse the repository at this point in the history

  6. bump css-bundle versions

    @markdalgleish
    markdalgleish committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    1dc7da5 View commit details
    Browse the repository at this point in the history

  7. add unstable_cssBundle default to test package

    @markdalgleish
    markdalgleish committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    5254c2e View commit details
    Browse the repository at this point in the history

  8. ensure scoped grid line names don't break build

    @markdalgleish
    markdalgleish committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    3117fe4 View commit details
    Browse the repository at this point in the history

  9. add CSS Modules to deterministic build test

    @markdalgleish
    markdalgleish committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    3e95c07 View commit details
    Browse the repository at this point in the history

  10. ensure stable hashes when using import composition

    @markdalgleish
    markdalgleish committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    78f74bd View commit details
    Browse the repository at this point in the history

  11. add comment explaining pattern order

    @markdalgleish
    markdalgleish committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    57f688c View commit details
    Browse the repository at this point in the history

  12. add comment about cwd limitation

    @markdalgleish
    markdalgleish committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    1e0c3a1 View commit details
    Browse the repository at this point in the history

  13. Merge branch 'dev' into markdalgleish/css-modules

    @markdalgleish
    markdalgleish committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    41f65cf View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2022

  1. add test for root relative image URLs

    @markdalgleish
    markdalgleish committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    d17e6cd View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2022

  1. Merge branch 'dev' into markdalgleish/css-modules

    @markdalgleish
    markdalgleish committed Dec 11, 2022
    Configuration menu
    Copy the full SHA
    0641e8c View commit details
    Browse the repository at this point in the history

  2. fix esbuild resolve error after upgrade

    @markdalgleish
    markdalgleish committed Dec 11, 2022
    Configuration menu
    Copy the full SHA
    c8b8c33 View commit details
    Browse the repository at this point in the history

  3. add CSS bundle deduplication test

    @markdalgleish
    markdalgleish committed Dec 11, 2022
    Configuration menu
    Copy the full SHA
    21c9e0b View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2022

  1. clean up tests

    @markdalgleish
    markdalgleish committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    568adf2 View commit details
    Browse the repository at this point in the history

  2. rename test

    @markdalgleish
    markdalgleish committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    de3e1c3 View commit details
    Browse the repository at this point in the history

  3. support import side effects in client entry

    @markdalgleish
    markdalgleish committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    039233b View commit details
    Browse the repository at this point in the history

  4. add trailing newline to tsconfig

    @markdalgleish
    markdalgleish committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    6ae02b2 View commit details
    Browse the repository at this point in the history

  5. update FutureConfig type, sort keys

    @markdalgleish
    markdalgleish committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    4a38a94 View commit details
    Browse the repository at this point in the history

  6. add changeset

    @markdalgleish
    markdalgleish committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    2c5eb5a View commit details
    Browse the repository at this point in the history

  7. add initial docs

    @markdalgleish
    markdalgleish committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    be5b9cc View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2022

  1. migrate to postcss-modules, add tests and clean up

    @markdalgleish
    markdalgleish committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    61ac3c5 View commit details
    Browse the repository at this point in the history

  2. hoist postcss imports

    @markdalgleish
    markdalgleish committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    9709d24 View commit details
    Browse the repository at this point in the history

  3. format tsconfig

    @markdalgleish
    markdalgleish committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    385aed5 View commit details
    Browse the repository at this point in the history

  4. reorder imports

    @markdalgleish
    markdalgleish committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    a774503 View commit details
    Browse the repository at this point in the history

  5. reorder options

    @markdalgleish
    markdalgleish committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    66b0ad8 View commit details
    Browse the repository at this point in the history

  6. add root relative class composition to test

    @markdalgleish
    markdalgleish committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    77080dd View commit details
    Browse the repository at this point in the history

  7. clean up css-bundle dist, add typings field

    @markdalgleish
    markdalgleish committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    beec55a View commit details
    Browse the repository at this point in the history

  8. Merge branch 'dev' into markdalgleish/css-modules

    @markdalgleish
    markdalgleish committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    778e4d2 View commit details
    Browse the repository at this point in the history

  9. update note about CSS Modules support

    @markdalgleish
    markdalgleish committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    a698f16 View commit details
    Browse the repository at this point in the history

  10. fix docs formatting

    @markdalgleish
    markdalgleish committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    ac9e013 View commit details
    Browse the repository at this point in the history

  11. update readme and description

    @markdalgleish
    markdalgleish committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    1bf956f View commit details
    Browse the repository at this point in the history

  12. update comment

    @markdalgleish
    markdalgleish committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    e06857c View commit details
    Browse the repository at this point in the history

  13. don't provide default object for entrypoints

    @markdalgleish
    markdalgleish committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    718909f View commit details
    Browse the repository at this point in the history

  14. remove redundant type annotations

    @markdalgleish
    markdalgleish committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    696e2c0 View commit details
    Browse the repository at this point in the history

  15. remove redundant relative path

    @markdalgleish
    markdalgleish committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    d05e29f View commit details
    Browse the repository at this point in the history

  16. simplify css compiler build step

    @markdalgleish
    markdalgleish committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    df3aa42 View commit details
    Browse the repository at this point in the history

  17. add comment explaining exports in css entry

    @markdalgleish
    markdalgleish committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    fffb86d View commit details
    Browse the repository at this point in the history

  18. add comment explaining resolved module contents

    @markdalgleish
    markdalgleish committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    5baeff3 View commit details
    Browse the repository at this point in the history

  19. simplify plugin data

    @markdalgleish
    markdalgleish committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    0243f83 View commit details
    Browse the repository at this point in the history

  20. use arrow functions for fixtures to reduce nesting

    @markdalgleish
    markdalgleish committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    3438678 View commit details
    Browse the repository at this point in the history

  21. nit formatting

    @markdalgleish
    markdalgleish committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    8fc72b6 View commit details
    Browse the repository at this point in the history

  22. switch from patch to minor release

    @markdalgleish
    markdalgleish committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    a5a1e27 View commit details
    Browse the repository at this point in the history

  23. convert unstable_cssBundle value to nested object

    @markdalgleish
    markdalgleish committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    806f033 View commit details
    Browse the repository at this point in the history

  24. reinstate relative path to improve CSS comments

    @markdalgleish
    markdalgleish committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    61088c2 View commit details
    Browse the repository at this point in the history

  25. Merge branch 'dev' into markdalgleish/css-modules

    @markdalgleish
    markdalgleish committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    a3e95d1 View commit details
    Browse the repository at this point in the history

  26. flatten CSS Modules feature flag

    @markdalgleish
    markdalgleish committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    6347b79 View commit details
    Browse the repository at this point in the history

  27. make virtual css paths relative to root dir

    @markdalgleish
    markdalgleish committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    84131d3 View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2022

  1. rename CSS entry module ID and plugin

    @markdalgleish
    markdalgleish committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    8257efc View commit details
    Browse the repository at this point in the history

  2. convert cssBundleHref to named export

    @markdalgleish
    markdalgleish committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    b8f6d42 View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2022

  1. Merge branch 'dev' into markdalgleish/css-modules

    @markdalgleish
    markdalgleish committed Dec 18, 2022
    Configuration menu
    Copy the full SHA
    7ed88e0 View commit details
    Browse the repository at this point in the history

  2. bump css-bundle versions

    @markdalgleish
    markdalgleish committed Dec 18, 2022
    Configuration menu
    Copy the full SHA
    2a5098e View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2022

  1. Merge branch 'dev' into markdalgleish/css-modules

    @markdalgleish
    markdalgleish committed Dec 19, 2022
    Configuration menu
    Copy the full SHA
    fa2d219 View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2022

  1. Merge branch 'dev' into markdalgleish/css-modules

    @markdalgleish
    markdalgleish committed Dec 20, 2022
    Configuration menu
    Copy the full SHA
    19dc2b7 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'dev' into markdalgleish/css-modules

    @markdalgleish
    markdalgleish committed Dec 20, 2022
    Configuration menu
    Copy the full SHA
    141ff02 View commit details
    Browse the repository at this point in the history

  3. don't output CSS Modules in server/app build

    @markdalgleish
    markdalgleish committed Dec 20, 2022
    Configuration menu
    Copy the full SHA
    aece1ee View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2022

  1. Update docs/guides/migrating-react-router-app.md 

    Co-authored-by: Chance Strickland <hi@chance.dev>
    @markdalgleish @chaance
    markdalgleish and chaance committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    fd6d3ed View commit details
    Browse the repository at this point in the history

  2. Update docs/guides/styling.md 

    Co-authored-by: Chance Strickland <hi@chance.dev>
    @markdalgleish @chaance
    markdalgleish and chaance committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    6a30fb5 View commit details
    Browse the repository at this point in the history

  3. Update docs/guides/styling.md 

    Co-authored-by: Chance Strickland <hi@chance.dev>
    @markdalgleish @chaance
    markdalgleish and chaance committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    cc96521 View commit details
    Browse the repository at this point in the history

  4. Update docs/guides/styling.md 

    Co-authored-by: Chance Strickland <hi@chance.dev>
    @markdalgleish @chaance
    markdalgleish and chaance committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    5cb0efb View commit details
    Browse the repository at this point in the history

  5. Update packages/remix-dev/compiler/compileBrowser.ts 

    Co-authored-by: Chance Strickland <hi@chance.dev>
    @markdalgleish @chaance
    markdalgleish and chaance committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    cc5dc69 View commit details
    Browse the repository at this point in the history

  6. Update packages/remix-dev/compiler/compileBrowser.ts 

    Co-authored-by: Chance Strickland <hi@chance.dev>
    @markdalgleish @chaance
    markdalgleish and chaance committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    3ebae45 View commit details
    Browse the repository at this point in the history

  7. Update docs/guides/styling.md 

    Co-authored-by: Chance Strickland <hi@chance.dev>
    @markdalgleish @chaance
    markdalgleish and chaance committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    f0c7b82 View commit details
    Browse the repository at this point in the history

  8. dedupe CSS in dev

    @markdalgleish
    markdalgleish committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    0da587d View commit details
    Browse the repository at this point in the history

  9. remove explicit single CSS file warning from docs

    @markdalgleish
    markdalgleish committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    c7357fa View commit details
    Browse the repository at this point in the history

  10. remove redundant optional chaining

    @markdalgleish
    markdalgleish committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    146ae5d View commit details
    Browse the repository at this point in the history

Commits on Dec 22, 2022

  1. Merge branch 'dev' into markdalgleish/css-modules

    @markdalgleish
    markdalgleish committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    ea9f2dc View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2023

  1. Merge branch 'dev' into markdalgleish/css-modules

    @markdalgleish
    markdalgleish committed Jan 3, 2023
    Configuration menu
    Copy the full SHA
    e42dd07 View commit details
    Browse the repository at this point in the history