Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: rename non public exports #4899

Closed
wants to merge 1 commit into from
Closed

chore: rename non public exports #4899

wants to merge 1 commit into from

Conversation

mcansh
Copy link
Collaborator

@mcansh mcansh commented Dec 16, 2022 •
edited

exposed a few things that were needed for @remix-run/testing but shouldn't be public API #4539

Signed-off-by: Logan McAnsh logan@mcan.sh

Closes: #

  • Docs
  • Tests

Testing Strategy:

@changeset-bot
Copy link

changeset-bot bot commented Dec 16, 2022 •
edited

⚠️ No Changeset found

Latest commit: 67ac7dd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mcansh mcansh marked this pull request as ready for review December 16, 2022 22:33
@mcansh
chore: rename non public exports
67ac7dd 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
brophdawg11
brophdawg11 approved these changes Dec 19, 2022
View reviewed changes
Copy link
Contributor

@brophdawg11 brophdawg11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we want to release this as a patch we may want to point this to a hotfix branch. Unsure if anything else has merged to dev since we released?

@mcansh
Copy link
Collaborator Author

mcansh commented Dec 21, 2022

closing in favor of the cleanup done in #4915

@mcansh mcansh closed this Dec 21, 2022
@mcansh mcansh deleted the logan/unsafe branch December 21, 2022 17:00
@mcansh mcansh mentioned this pull request Dec 21, 2022
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brophdawg11 brophdawg11 brophdawg11 approved these changes

@MichaelDeBoey MichaelDeBoey MichaelDeBoey approved these changes

Assignees
No one assigned
Labels
CLA Signed package:testing renderer:react
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mcansh @brophdawg11 @MichaelDeBoey