Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: run tests with node 19.7 #5807

Merged
merged 1 commit into from Mar 15, 2023
Merged

ci: run tests with node 19.7 #5807

merged 1 commit into from Mar 15, 2023

Conversation

mcansh
Copy link
Collaborator

@mcansh mcansh commented Mar 15, 2023

19.8 is no good

related nodejs/node#47096


Building Remix app in production mode...
node[78803]: ../src/module_wrap.cc:599:MaybeLocal<v8::Promise> node::loader::ImportModuleDynamically(Local<v8::Context>, Local<v8::Data>, Local<v8::Value>, Local<v8::String>, Local<v8::FixedArray>): Assertion `(it) != (env->id_to_function_map.end())' failed.
 1: 0x104488e00 node::Abort() [/Users/logan/.n/bin/node]
 2: 0x104488bcc node::PrintCaughtException(v8::Isolate*, v8::Local<v8::Context>, v8::TryCatch const&) [/Users/logan/.n/bin/node]
 3: 0x10445132c node::loader::ImportModuleDynamically(v8::Local<v8::Context>, v8::Local<v8::Data>, v8::Local<v8::Value>, v8::Local<v8::String>, v8::Local<v8::FixedArray>) [/Users/logan/.n/bin/node]
 4: 0x10473892c v8::internal::Isolate::RunHostImportModuleDynamicallyCallback(v8::internal::MaybeHandle<v8::internal::Script>, v8::internal::Handle<v8::internal::Object>, v8::internal::MaybeHandle<v8::internal::Object>) [/Users/logan/.n/bin/node]
 5: 0x104b3f604 v8::internal::Runtime_DynamicImportCall(int, unsigned long*, v8::internal::Isolate*) [/Users/logan/.n/bin/node]
 6: 0x104ecb524 Builtins_CEntry_Return1_DontSaveFPRegs_ArgvInRegister_NoBuiltinExit [/Users/logan/.n/bin/node]
 7: 0x104f7049c Builtins_CallRuntimeHandler [/Users/logan/.n/bin/node]
 8: 0x104e48064 Builtins_InterpreterEntryTrampoline [/Users/logan/.n/bin/node]
 9: 0x104e48064 Builtins_InterpreterEntryTrampoline [/Users/logan/.n/bin/node]
10: 0x104e7e8b4 Builtins_AsyncFunctionAwaitResolveClosure [/Users/logan/.n/bin/node]
11: 0x104f1ee38 Builtins_PromiseFulfillReactionJob [/Users/logan/.n/bin/node]
12: 0x104e6e834 Builtins_RunMicrotasks [/Users/logan/.n/bin/node]
13: 0x104e463c4 Builtins_JSRunMicrotasksEntry [/Users/logan/.n/bin/node]
14: 0x10471b9a0 v8::internal::(anonymous namespace)::Invoke(v8::internal::Isolate*, v8::internal::(anonymous namespace)::InvokeParams const&) [/Users/logan/.n/bin/node]
15: 0x10471be90 v8::internal::(anonymous namespace)::InvokeWithTryCatch(v8::internal::Isolate*, v8::internal::(anonymous namespace)::InvokeParams const&) [/Users/logan/.n/bin/node]
16: 0x10471c06c v8::internal::Execution::TryRunMicrotasks(v8::internal::Isolate*, v8::internal::MicrotaskQueue*) [/Users/logan/.n/bin/node]
17: 0x104743fe4 v8::internal::MicrotaskQueue::RunMicrotasks(v8::internal::Isolate*) [/Users/logan/.n/bin/node]
18: 0x104744880 v8::internal::MicrotaskQueue::PerformCheckpoint(v8::Isolate*) [/Users/logan/.n/bin/node]
19: 0x1043d0c50 node::InternalCallbackScope::Close() [/Users/logan/.n/bin/node]
20: 0x1043d07c4 node::InternalCallbackScope::~InternalCallbackScope() [/Users/logan/.n/bin/node]
21: 0x10448ccac node::fs::FileHandle::CloseReq::Resolve() [/Users/logan/.n/bin/node]
22: 0x1044a3574 node::fs::FileHandle::ClosePromise()::$_0::__invoke(uv_fs_s*) [/Users/logan/.n/bin/node]
23: 0x104485034 node::MakeLibuvRequestCallback<uv_fs_s, void (*)(uv_fs_s*)>::Wrapper(uv_fs_s*) [/Users/logan/.n/bin/node]
24: 0x104e22410 uv__work_done [/Users/logan/.n/bin/node]
25: 0x104e25bb8 uv__async_io [/Users/logan/.n/bin/node]
26: 0x104e3835c uv__io_poll [/Users/logan/.n/bin/node]
27: 0x104e26088 uv_run [/Users/logan/.n/bin/node]
28: 0x1043d16f4 node::SpinEventLoopInternal(node::Environment*) [/Users/logan/.n/bin/node]
29: 0x1044c5ee4 node::NodeMainInstance::Run() [/Users/logan/.n/bin/node]
30: 0x104456260 node::LoadSnapshotDataAndRun(node::SnapshotData const**, node::InitializationResultImpl const*) [/Users/logan/.n/bin/node]
31: 0x1044564c8 node::Start(int, char**) [/Users/logan/.n/bin/node]
32: 0x185cf3e50 start [/usr/lib/dyld]
sh: line 1: 78803 Abort trap: 6           remix build

Closes: #

  • Docs
  • Tests

Testing Strategy:

19.8 is bad

Signed-off-by: Logan McAnsh <logan@mcan.sh>
@changeset-bot
Copy link

changeset-bot bot commented Mar 15, 2023

⚠️ No Changeset found

Latest commit: d9b4847

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mcansh mcansh changed the title Logan/ci use 19.7 ci: run tests with node 19.7 Mar 15, 2023
@mcansh mcansh merged commit 2072f33 into dev Mar 15, 2023
@mcansh mcansh deleted the logan/ci-use-19.7 branch March 15, 2023 03:59
mcansh added a commit that referenced this pull request Mar 15, 2023
Signed-off-by: Logan McAnsh <logan@mcan.sh>
(cherry picked from commit 2072f33)
mcansh added a commit that referenced this pull request Mar 15, 2023
Signed-off-by: Logan McAnsh <logan@mcan.sh>
(cherry picked from commit 2072f33)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant