Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for custom Puppeteer / Apple M1 support #132
Support for custom Puppeteer / Apple M1 support #132
Changes from 4 commits
cffba1b
071ecc1
018ddf3
1932756
619db02
10b0c47
a065997
54a18dd
a5284d6
188b910
e498176
7ecee8b
da6e08e
3d9ff8c
c7a9634
eb35b32
9efa99c
93a9e43
3278c10
898e75c
a1d5997
bc25761
7a9b1b1
62d2bd4
803ad08
ddf9316
e564473
03cc7be
cc9a841
2817e0e
303cdde
034f5f1
adc86c8
f1d72df
6a49440
f27602d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty impressive!
So this will only work if someone has exactly Chrome 84.8005 installed though? 🤔 Might be a bit too strict, maybe better to check for path (e.g. /Applications/Google Chrome.app)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually 848005 corresponds to Chromium 90.0.4403.0.
To check for executable path for chrome or chromium for each os is a bit complicated than it seems. Figuring out how to write the script for chrome or chromium executable for each os.
Currently how it works (in linux) is that if you don't have the chormium executable in
puppeteer-core
it downloads the defaultChromium 90.0.4403.0
innode-modules/puppeteer-core/.local-chromium
and from the next time it automatically detects the executable path in.local-chromium
and use that chromium executable.