Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamically detect Windows drive letter #1333

Merged
merged 3 commits into from Sep 22, 2022
Merged

Conversation

patsalv
Copy link
Contributor

@patsalv patsalv commented Sep 22, 2022

Testcase now uses automatically determined root in order to no longer have C:\ and D:\ clashes

@vercel
Copy link

vercel bot commented Sep 22, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
remotion ✅ Ready (Inspect) Visit Preview Sep 22, 2022 at 10:28AM (UTC)

@JonnyBurger
Copy link
Member

Should only use the custom root on Windows, also please remove log and tsconfig change!

+ removed console.log()
@JonnyBurger JonnyBurger changed the title automatic root directory Dynamically detect Windows drive letter Sep 22, 2022
@JonnyBurger
Copy link
Member

Thanks!

@JonnyBurger JonnyBurger merged commit 9bdd434 into main Sep 22, 2022
@JonnyBurger JonnyBurger deleted the testcase-dynamic-root branch September 22, 2022 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants