imageFormat, maxRetries, privacy are optional for renderMediaOnMedia
#1355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@JonnyBurger which version would this PR ship to? Or which version should I mention in docs the optional started? |
|
@uragirii It would ship to the next patch version: v3.2.26 |
|
Ready for review ✨ |
|
LGTM! Thanks a lot for your contribution! 🙌 For statistics: How long do you think you approximately worked on this PR? |
10-15mins iirc 🤔 |
|
@uragirii Nice, thanks 😁 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes
imageFormat,maxRetries,privacyoptional for renderMediaOnMedia. Fixes #1348I have also added "optional" in the relevant documentation for the parameters.
Default values for these params are:
IssueHunt Summary
Referenced issues
This pull request has been submitted to:
imageFormat,maxRetries,privacyshould not be mandatory for renderMediaOnLambda()